From 6165d66760cc69d16da25ca372c6de77f8c1c589 Mon Sep 17 00:00:00 2001 From: agent-company Date: Mon, 20 Apr 2026 23:05:42 +0000 Subject: [PATCH] Fix scheduler tests to use get_db_client after scheduler refactor The scheduler was refactored (PR #1665) to use the pooled get_db_client() from SPARC.auth instead of creating its own DatabaseClient. Update test mocks accordingly and remove the db.close() assertion since the pooled client is no longer closed by the scheduler. Co-Authored-By: Claude Opus 4.6 (1M context) --- tests/test_tracked_companies.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/test_tracked_companies.py b/tests/test_tracked_companies.py index d1e96fa..df25134 100644 --- a/tests/test_tracked_companies.py +++ b/tests/test_tracked_companies.py @@ -272,7 +272,7 @@ class TestSchedulerIntegration: mock_db = MagicMock() mock_db.list_tracked_companies.return_value = [] - with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ + with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \ patch("SPARC.scheduler.CompanyAnalyzer") as mock_analyzer_cls: from SPARC.scheduler import run_scheduled_analysis run_scheduled_analysis() @@ -292,7 +292,7 @@ class TestSchedulerIntegration: mock_analyzer = MagicMock() mock_analyzer._analyze_company_safe.side_effect = [mock_result_nvidia, mock_result_amd] - with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ + with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \ patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): from SPARC.scheduler import run_scheduled_analysis run_scheduled_analysis() @@ -312,7 +312,7 @@ class TestSchedulerIntegration: mock_analyzer = MagicMock() mock_analyzer._analyze_company_safe.return_value = mock_result - with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ + with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \ patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): from SPARC.scheduler import run_scheduled_analysis run_scheduled_analysis() @@ -335,7 +335,7 @@ class TestSchedulerIntegration: mock_analyzer = MagicMock() mock_analyzer._analyze_company_safe.return_value = mock_result - with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ + with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \ patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): from SPARC.scheduler import run_scheduled_analysis run_scheduled_analysis() @@ -355,7 +355,7 @@ class TestSchedulerIntegration: mock_analyzer = MagicMock() mock_analyzer._analyze_company_safe.side_effect = [mock_fail_result, mock_ok_result] - with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ + with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \ patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): from SPARC.scheduler import run_scheduled_analysis run_scheduled_analysis() @@ -378,11 +378,10 @@ class TestSchedulerIntegration: mock_ok_result, ] - with patch("SPARC.scheduler.DatabaseClient", return_value=mock_db), \ + with patch("SPARC.scheduler.get_db_client", return_value=mock_db), \ patch("SPARC.scheduler.CompanyAnalyzer", return_value=mock_analyzer): from SPARC.scheduler import run_scheduled_analysis run_scheduled_analysis() # OKCo should still be processed mock_db.update_tracked_company.assert_called_once_with("OKCo", 22) - mock_db.close.assert_called_once()