mirror of
https://github.com/0xWheatyz/handler.git
synced 2026-08-30 03:31:36 +00:00
fix(login): capture the full claude auth URL on a wide tmux window
Testing the web login surfaced a truncated authorization URL (…client_id=9d1c250a-e61b-44d9-88) and a "missing redirect_uri" error: the login session ran at the default 80 columns, so claude clipped the long URL and capture-pane read it back cut off. - Launch the login session with a very wide, tall window (500x50) via new optional width/height on tmux.new_session, so claude prints the URL on one unclipped line. - Harden URL extraction to stop at box-drawing glyphs (U+2500–U+257F) in case the TUI renders the link flush against a border. Tests: assert the wide window is requested, and that extraction keeps a full redirect_uri/PKCE URL intact and strips a trailing box border. Suite green (197). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YKVyBmKvWDVgrFC9WER2f2
This commit is contained in:
+3
-2
@@ -79,9 +79,10 @@ def fake_tmux(monkeypatch):
|
||||
|
||||
from handler.control import tmux
|
||||
|
||||
def new_session(name, cwd, command, env):
|
||||
def new_session(name, cwd, command, env, *, width=None, height=None):
|
||||
calls["new_session"].append(
|
||||
{"name": name, "cwd": cwd, "command": command, "env": env}
|
||||
{"name": name, "cwd": cwd, "command": command, "env": env,
|
||||
"width": width, "height": height}
|
||||
)
|
||||
live.add(name)
|
||||
|
||||
|
||||
@@ -43,6 +43,24 @@ def test_extract_url_none_when_no_link():
|
||||
assert login._extract_url("no link here") is None
|
||||
|
||||
|
||||
def test_extract_url_stops_at_box_border():
|
||||
# claude may draw the URL inside a rounded box; a "│" flush against the link must not
|
||||
# be captured as part of the URL.
|
||||
assert login._extract_url(f"│{AUTH_URL}│") == AUTH_URL
|
||||
|
||||
|
||||
def test_extract_url_captures_full_long_url_with_redirect_uri():
|
||||
# The real login URL carries redirect_uri + PKCE; on a wide pane it arrives intact and
|
||||
# extraction must not clip it (the truncation-at-80-cols bug was in capture, not here).
|
||||
long_url = (
|
||||
"https://claude.ai/oauth/authorize?code=true&client_id=9d1c250a-e61b-44d9-88ab-"
|
||||
"0123456789ab&response_type=code&redirect_uri=https%3A%2F%2Fconsole.anthropic.com"
|
||||
"%2Foauth%2Fcode%2Fcallback&scope=org%3Acreate_api_key+user%3Aprofile&"
|
||||
"code_challenge=abcDEF123&code_challenge_method=S256&state=xyz789"
|
||||
)
|
||||
assert login._extract_url(f"Use this URL to sign in:\n{long_url}") == long_url
|
||||
|
||||
|
||||
def test_start_launches_claude_selects_subscription_and_returns_url(
|
||||
env, fake_tmux, no_sleep, monkeypatch
|
||||
):
|
||||
@@ -56,6 +74,9 @@ def test_start_launches_claude_selects_subscription_and_returns_url(
|
||||
assert len(launched) == 1
|
||||
assert launched[0]["name"] == login.LOGIN_SESSION
|
||||
assert launched[0]["command"] == "claude"
|
||||
# A wide window so the long authorization URL isn't clipped at 80 columns.
|
||||
assert launched[0]["width"] == login.LOGIN_COLS
|
||||
assert launched[0]["height"] == login.LOGIN_ROWS
|
||||
# …then /login was sent, followed by a bare Enter selecting the subscription option.
|
||||
sent = [c["keys"] for c in fake_tmux["calls"]["send_keys"]]
|
||||
assert sent[:2] == ["/login", ""]
|
||||
|
||||
Reference in New Issue
Block a user