mirror of
https://github.com/0xWheatyz/handler.git
synced 2026-08-30 14:46:25 +00:00
Claude
4f05d09c2b
Make credentials/hosts, projects, agents, and approvals manageable from the dashboard. The API and control layer are separate containers, so the API can't run control actions directly (no git/tmux/claude, doesn't own the tmux sessions). Instead the API enqueues a command and a worker in the control container executes it and writes the result back. Data model (migration 0003): - `commands` queue/audit table; `forge_hosts` registry; `approvals` gains a nullable approver id + `actor` so operator verdicts are first-class. Control worker: - `control/worker.py` claims commands and dispatches to the existing control functions (spawn/kill/resume/record_approval/write_skills/poller.sweep), plus a periodic CI sweep. New `handler worker` CLI subcommand; it becomes the control image's default command (subsumes `poll-ci --watch`). API: - `require_admin` gate + `ADMIN_TOKEN`; project GET/PATCH/DELETE; agent spawn/kill/delete; resume now enqueues (fixes a cross-container bug where the API tried to send tmux keys to a session in the control container); new approvals/commands/hosts routes; forge-init and poll-ci enqueue endpoints. Credentials/hosts: - host->token-env lookup consults the `forge_hosts` registry first (built-in map is the fallback); `resolve()` refactored to a scheme dispatch reserving `db:` for a future encrypted store. Web input restricts credential_ref to env:/file:/db: (cmd: stays CLI-only — it would run arbitrary commands). Dashboard: - New tabs for projects, agents (spawn/kill with live command-status polling), approvals, hosts, and an activity/audit view; shared context is now writable. Tests: +33 (queue atomicity, worker dispatch, CRUD, hosts, admin gating, cmd: rejection, host-aware credentials, and an API->queue->worker->spawn end-to-end). README gains a Web management section. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CrhrBToauu4L2qG6jdnuFP
127 lines
4.3 KiB
Python
127 lines
4.3 KiB
Python
"""The control worker: command dispatch + the claim/finish plumbing.
|
|
|
|
Uses the same mock seams as the CLI tests (tmux/gitops/forge/spawn.resume) plus direct
|
|
monkeypatching of spawn.spawn/kill so we exercise the worker's routing, not the full spawn
|
|
machinery (already covered by test_control_spawn)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from handler.control import poller, spawn, worker
|
|
from handler.db import repository as repo
|
|
from handler.db.engine import get_engine
|
|
|
|
|
|
def _seed_project(agent=None):
|
|
with get_engine().begin() as conn:
|
|
repo.create_project(conn, "p", "/tmp/p")
|
|
if agent:
|
|
repo.create_agent(conn, "p", agent, f"/tmp/p/{agent}", status="paused_for_input")
|
|
|
|
|
|
def _enqueue(**kw):
|
|
with get_engine().begin() as conn:
|
|
return repo.enqueue_command(conn, **kw)
|
|
|
|
|
|
def _get(cmd_id):
|
|
with get_engine().begin() as conn:
|
|
return repo.get_command(conn, cmd_id)
|
|
|
|
|
|
def test_spawn_command_calls_spawn_and_records_result(env, monkeypatch):
|
|
_seed_project()
|
|
calls = {}
|
|
|
|
def fake_spawn(project_id, name, **kw):
|
|
calls.update(project_id=project_id, name=name, **kw)
|
|
return {"id": 42, "name": name, "working_dir": "/tmp/p/j", "forge_note": None}
|
|
|
|
monkeypatch.setattr(spawn, "spawn", fake_spawn)
|
|
cmd = _enqueue(
|
|
type="spawn", project_id="p", agent_name="j",
|
|
payload={"role": "junior", "worktree": "feat/x"},
|
|
)
|
|
|
|
assert worker.drain("w") == 1
|
|
done = _get(cmd["id"])
|
|
assert done["status"] == "done"
|
|
assert done["result"]["agent_id"] == 42
|
|
assert calls["project_id"] == "p" and calls["name"] == "j"
|
|
assert calls["role"] == "junior" and calls["worktree_branch"] == "feat/x"
|
|
|
|
|
|
def test_kill_command_calls_kill(env, monkeypatch):
|
|
_seed_project("api")
|
|
killed = {}
|
|
monkeypatch.setattr(spawn, "kill", lambda p, n: killed.update(project=p, name=n))
|
|
cmd = _enqueue(type="kill", project_id="p", agent_name="api")
|
|
|
|
worker.drain("w")
|
|
assert _get(cmd["id"])["status"] == "done"
|
|
assert killed == {"project": "p", "name": "api"}
|
|
|
|
|
|
def test_resume_command_feeds_answer_and_sets_working(env, monkeypatch):
|
|
_seed_project("api")
|
|
seen = {}
|
|
|
|
def fake_resume(agent, ans):
|
|
seen.update(name=agent["name"], ans=ans)
|
|
return True, "ok"
|
|
|
|
monkeypatch.setattr(spawn, "resume", fake_resume)
|
|
cmd = _enqueue(type="resume", project_id="p", agent_name="api", payload={"answer": "Postgres"})
|
|
|
|
worker.drain("w")
|
|
assert _get(cmd["id"])["status"] == "done"
|
|
assert seen == {"name": "api", "ans": "Postgres"}
|
|
with get_engine().begin() as conn:
|
|
assert repo.get_agent_by_name(conn, "p", "api")["status"] == "working"
|
|
|
|
|
|
def test_approve_command_records_operator_verdict_with_head_sha(env, fake_gitops):
|
|
_seed_project("senior")
|
|
cmd = _enqueue(
|
|
type="approve", project_id="p", agent_name="senior", payload={"branch": "feat/x"}
|
|
)
|
|
|
|
worker.drain("w")
|
|
assert _get(cmd["id"])["status"] == "done"
|
|
with get_engine().begin() as conn:
|
|
ap = repo.get_latest_approval(conn, "p", "feat/x")
|
|
assert ap["status"] == "approved"
|
|
assert ap["actor"] == "operator:web"
|
|
assert ap["approved_by_agent_id"] is None
|
|
assert ap["approved_sha"] == fake_gitops["sha"] # read from the agent's working dir
|
|
|
|
|
|
def test_poll_ci_command_returns_summary(env, monkeypatch):
|
|
_seed_project()
|
|
summary = {"checked": 0, "resolved": 0, "pending": 0}
|
|
monkeypatch.setattr(poller, "sweep", lambda project_id=None: summary)
|
|
cmd = _enqueue(type="poll_ci", project_id="p")
|
|
|
|
worker.drain("w")
|
|
done = _get(cmd["id"])
|
|
assert done["status"] == "done"
|
|
assert done["result"] == {"checked": 0, "resolved": 0, "pending": 0}
|
|
|
|
|
|
def test_bad_command_is_recorded_failed_not_raised(env):
|
|
# spawn with no agent name -> CommandError -> the worker records 'failed', keeps going.
|
|
_seed_project()
|
|
cmd = _enqueue(type="spawn", project_id="p")
|
|
assert worker.drain("w") == 1
|
|
failed = _get(cmd["id"])
|
|
assert failed["status"] == "failed"
|
|
assert "agent name" in failed["error"]
|
|
|
|
|
|
def test_drain_processes_multiple_then_stops(env, monkeypatch):
|
|
_seed_project()
|
|
monkeypatch.setattr(poller, "sweep", lambda project_id=None: {"checked": 0})
|
|
_enqueue(type="poll_ci", project_id="p")
|
|
_enqueue(type="poll_ci", project_id="p")
|
|
assert worker.drain("w") == 2
|
|
assert worker.drain("w") == 0 # queue now empty
|