ci: add tsc --noEmit TypeScript type checking to CI pipeline

Upgrade lucide-react to v1.7.0 for proper TypeScript declarations and
add a TypeScript type check step to the test workflow. Both ruff (Python)
and tsc --noEmit (TypeScript) now block merging on failure.

Closes leeworks-agents/SPARC#52

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

.gitea/workflows/test.yaml

@@ -34,6 +34,17 @@ jobs:
         run: |
           ruff check SPARC/ tests/
 
+      - name: Install Node.js and frontend dependencies
+        shell: sh
+        run: |
+          apk add --no-cache nodejs npm
+          cd frontend && npm ci
+
+      - name: Run TypeScript type check
+        shell: sh
+        run: |
+          cd frontend && npx tsc --noEmit
+
       - name: Run pytest
         shell: sh
         env:

SPARC/api.py

@@ -77,13 +77,6 @@ class JobStatus(BaseModel):
     error: str | None = None
 
 
-class PaginatedJobsResponse(BaseModel):
-    """Paginated response for job listings."""
-
-    items: list["JobStatus"]
-    next_cursor: str | None = None
-
-
 class HealthResponse(BaseModel):
     """Health check response."""
 
@@ -584,51 +577,24 @@ async def get_job_status(
     return _job_row_to_status(job_row)
 
 
-@app.get("/jobs", response_model=PaginatedJobsResponse, tags=["Jobs"])
+@app.get("/jobs", response_model=list[JobStatus], tags=["Jobs"])
 async def list_jobs(
     status: Annotated[
         str | None,
         Query(description="Filter by status: pending, running, completed, failed"),
     ] = None,
     limit: Annotated[int, Query(ge=1, le=100)] = 10,
-    cursor: Annotated[
-        str | None,
-        Query(description="Opaque cursor from a previous response's next_cursor field"),
-    ] = None,
     _: UserResponse = Depends(get_current_user),
 ):
-    """List analysis jobs with cursor-based pagination.
+    """List all analysis jobs.
-
-    Pass ``limit`` to control page size. The response includes a ``next_cursor``
-    field; pass it back as the ``cursor`` query parameter to fetch the next page.
-    When ``next_cursor`` is ``null``, there are no more results.
-
-    Existing clients that use only ``limit`` (without ``cursor``) continue to
-    work without modification.
 
     Args:
         status: Optional filter by job status
         limit: Maximum number of jobs to return (default 10, max 100)
-        cursor: Opaque pagination cursor from a previous response
 
     Returns:
-        Paginated list of job statuses
+        List of job statuses
     """
     db = _get_job_db()
-    # Fetch one extra to determine if there is a next page
+    job_rows = db.list_jobs(status=status, limit=limit)
-    job_rows = db.list_jobs(status=status, limit=limit + 1, cursor=cursor)
+    return [_job_row_to_status(row) for row in job_rows]
-
-    has_next = len(job_rows) > limit
-    if has_next:
-        job_rows = job_rows[:limit]
-
-    items = [_job_row_to_status(row) for row in job_rows]
-
-    next_cursor = None
-    if has_next and job_rows:
-        last = job_rows[-1]
-        created = last["created_at"]
-        ts = created.isoformat() if hasattr(created, "isoformat") else str(created)
-        next_cursor = f"{ts}|{last['job_id']}"
-
-    return PaginatedJobsResponse(items=items, next_cursor=next_cursor)

SPARC/database.py

@@ -568,45 +568,20 @@ class DatabaseClient:
         self,
         status: Optional[str] = None,
         limit: int = 10,
-        cursor: Optional[str] = None,
     ) -> List[Dict]:
-        """List jobs with optional status filter and cursor-based pagination.
+        """List jobs, optionally filtered by status."""
-
-        Args:
-            status: Optional status filter (pending, running, completed, failed).
-            limit: Maximum number of jobs to return.
-            cursor: Opaque cursor (``created_at|job_id``) from a previous
-                response. When provided, only jobs older than the cursor are
-                returned.
-
-        Returns:
-            List of job dicts ordered by created_at descending.
-        """
-        conditions: list[str] = []
-        params: list = []
-
-        if status:
-            conditions.append("status = %s")
-            params.append(status)
-
-        if cursor:
-            try:
-                ts_str, cursor_job_id = cursor.rsplit("|", 1)
-                conditions.append("(created_at, job_id) < (%s, %s)")
-                params.extend([ts_str, cursor_job_id])
-            except ValueError:
-                pass  # Ignore malformed cursors; return from start
-
         query = "SELECT * FROM jobs"
-        if conditions:
+        params: list = []
-            query += " WHERE " + " AND ".join(conditions)
+        if status:
-        query += " ORDER BY created_at DESC, job_id DESC LIMIT %s"
+            query += " WHERE status = %s"
+            params.append(status)
+        query += " ORDER BY created_at DESC LIMIT %s"
         params.append(limit)
 
         with self.get_conn() as conn:
-            with conn.cursor(cursor_factory=RealDictCursor) as cur:
+            with conn.cursor(cursor_factory=RealDictCursor) as cursor:
-                cur.execute(query, params)
+                cursor.execute(query, params)
-                return [dict(row) for row in cur.fetchall()]
+                return [dict(row) for row in cursor.fetchall()]
 
     def mark_stale_jobs_failed(self) -> int:
         """Mark any jobs in 'running' or 'pending' state as 'failed'.

frontend/package-lock.json

@@ -10,7 +10,7 @@
       "dependencies": {
         "@tanstack/react-query": "^5.51.0",
         "axios": "^1.7.2",
-        "lucide-react": "^0.400.0",
+        "lucide-react": "^1.7.0",
         "react": "^18.3.1",
         "react-dom": "^18.3.1",
         "react-router-dom": "^6.24.0",
@@ -3452,9 +3452,9 @@
       }
     },
     "node_modules/lucide-react": {
-      "version": "0.400.0",
+      "version": "1.7.0",
-      "resolved": "https://registry.npmjs.org/lucide-react/-/lucide-react-0.400.0.tgz",
+      "resolved": "https://registry.npmjs.org/lucide-react/-/lucide-react-1.7.0.tgz",
-      "integrity": "sha512-rpp7pFHh3Xd93KHixNgB0SqThMHpYNzsGUu69UaQbSZ75Q/J3m5t6EhKyMT3m4w2WOxmJ2mY0tD3vebnXqQryQ==",
+      "integrity": "sha512-yI7BeItCLZJTXikmK4KNUGCKoGzSvbKlfCvw44bU4fXAL6v3gYS4uHD1jzsLkfwODYwI6Drw5Tu9Z5ulDe0TSg==",
       "license": "ISC",
       "peerDependencies": {
         "react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0"

frontend/package.json

@@ -7,12 +7,13 @@
     "dev": "vite",
     "build": "tsc -b && vite build",
     "lint": "eslint .",
+    "typecheck": "tsc --noEmit",
     "preview": "vite preview"
   },
   "dependencies": {
     "@tanstack/react-query": "^5.51.0",
     "axios": "^1.7.2",
-    "lucide-react": "^0.400.0",
+    "lucide-react": "^1.7.0",
     "react": "^18.3.1",
     "react-dom": "^18.3.1",
     "react-router-dom": "^6.24.0",