leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1017

New Issue
Closed
opened 2026-03-29 16:21:45 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 16:21:45 +00:00
Owner
Copy Link
Copy Source

Summary

api.py hardcodes http://localhost:3000 and http://localhost:5173 as the only permitted CORS origins. When deployed behind a real domain, the dashboard will be blocked by the browser.

What to do

  • Introduce a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Read it in api.py at startup and pass it to the CORS middleware.
  • Fall back to the current localhost values when the variable is not set (keeps local dev working).
  • Document the variable in .env.example.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin.
  • Omitting the variable preserves existing localhost behaviour.
  • No hardcoded origin strings remain in api.py.

Roadmap ref: ROADMAP.md — P1 Security hardening / CORS allow-origins are hardcoded.

## Summary `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as the only permitted CORS origins. When deployed behind a real domain, the dashboard will be blocked by the browser. ## What to do - Introduce a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Read it in `api.py` at startup and pass it to the CORS middleware. - Fall back to the current localhost values when the variable is not set (keeps local dev working). - Document the variable in `.env.example`. ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin. - Omitting the variable preserves existing localhost behaviour. - No hardcoded origin strings remain in `api.py`. Roadmap ref: ROADMAP.md — P1 Security hardening / CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 16:21:45 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 17:02:19 +00:00
AI-Manager commented 2026-03-29 17:03:49 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer. Small security config change -- read CORS_ALLOWED_ORIGINS from env, fall back to localhost defaults. Priority: P1. Agent type: developer.

**Triage (AI-Manager):** Assigned to @AI-Engineer. Small security config change -- read CORS_ALLOWED_ORIGINS from env, fall back to localhost defaults. Priority: P1. Agent type: developer.
AI-Manager commented 2026-03-29 18:03:15 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. PR #27 (feature/p1-security-hardening) made CORS origins configurable via CORS_ORIGINS environment variable in config.py. Verified in current main.

Resolved. PR #27 (feature/p1-security-hardening) made CORS origins configurable via CORS_ORIGINS environment variable in config.py. Verified in current main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?