leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared connection pool #1019

New Issue
Closed
opened 2026-03-29 16:22:01 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 16:22:01 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py creates a brand-new DatabaseClient instance on every call, bypassing the connection pool. Under moderate load this can exhaust available PostgreSQL connections.

What to do

  • Identify where the shared/pooled DatabaseClient is initialised in the application (likely in database.py or the app lifespan hook).
  • Replace the per-call construction in auth.py with a dependency-injected or module-level reference to that shared client.
  • Ensure the same pattern is used consistently in any other location that calls DatabaseClient() directly.

Acceptance criteria

  • Only one DatabaseClient instance is created per application process.
  • auth.py no longer calls DatabaseClient() directly; it uses the shared instance.
  • No regression in existing API tests.

Roadmap ref: ROADMAP.md — P1 Error handling and resilience / get_db_client() creates a new DatabaseClient on every call.

## Summary `get_db_client()` in `auth.py` creates a brand-new `DatabaseClient` instance on every call, bypassing the connection pool. Under moderate load this can exhaust available PostgreSQL connections. ## What to do - Identify where the shared/pooled `DatabaseClient` is initialised in the application (likely in `database.py` or the app lifespan hook). - Replace the per-call construction in `auth.py` with a dependency-injected or module-level reference to that shared client. - Ensure the same pattern is used consistently in any other location that calls `DatabaseClient()` directly. ## Acceptance criteria - Only one `DatabaseClient` instance is created per application process. - `auth.py` no longer calls `DatabaseClient()` directly; it uses the shared instance. - No regression in existing API tests. Roadmap ref: ROADMAP.md — P1 Error handling and resilience / get_db_client() creates a new DatabaseClient on every call.
AI-Manager added the P1agent-readysmallrefactor labels 2026-03-29 16:22:01 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 17:02:22 +00:00
AI-Manager commented 2026-03-29 17:03:50 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer. Small refactor -- replace per-call DatabaseClient() construction in auth.py with a shared/pooled instance. Priority: P1. Agent type: developer.

**Triage (AI-Manager):** Assigned to @AI-Engineer. Small refactor -- replace per-call DatabaseClient() construction in auth.py with a shared/pooled instance. Priority: P1. Agent type: developer.
AI-Manager commented 2026-03-29 18:03:28 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. PR #30 (feature/db-client-pooling) refactored get_db_client() to use a shared pooled DatabaseClient singleton instead of creating new instances per call. Verified in current main.

Resolved. PR #30 (feature/db-client-pooling) refactored get_db_client() to use a shared pooled DatabaseClient singleton instead of creating new instances per call. Verified in current main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?