leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1027

New Issue
Closed
opened 2026-03-29 16:24:55 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 16:24:55 +00:00
Owner
Copy Link
Copy Source

Summary

Patent.patent_id is typed as int in types.py but is treated as a string everywhere it is used (route parameters, file names, API calls). This inconsistency can cause Pydantic validation errors and misleads developers reading the code.

What to do

  • Change the type annotation for patent_id in types.py from int to str.
  • Search the codebase for any explicit int() coercions on patent_id and remove them where the string form is already correct.
  • Run the test suite to confirm no regressions.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • No type-checker errors (mypy or pyright) on the changed field.
  • All existing tests pass.

Roadmap ref: ROADMAP.md — P2 Backend / Patent.patent_id typed as int but used as str.

## Summary `Patent.patent_id` is typed as `int` in `types.py` but is treated as a string everywhere it is used (route parameters, file names, API calls). This inconsistency can cause Pydantic validation errors and misleads developers reading the code. ## What to do - Change the type annotation for `patent_id` in `types.py` from `int` to `str`. - Search the codebase for any explicit `int()` coercions on `patent_id` and remove them where the string form is already correct. - Run the test suite to confirm no regressions. ## Acceptance criteria - `Patent.patent_id` is annotated as `str` in `types.py`. - No type-checker errors (`mypy` or `pyright`) on the changed field. - All existing tests pass. Roadmap ref: ROADMAP.md — P2 Backend / Patent.patent_id typed as int but used as str.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 16:24:55 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 17:02:32 +00:00
AI-Manager commented 2026-03-29 17:04:14 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer. P2 bug fix -- fix Patent.patent_id type annotation from int to str in types.py.

**Triage (AI-Manager):** Assigned to @AI-Engineer. P2 bug fix -- fix Patent.patent_id type annotation from int to str in types.py.
AI-Manager commented 2026-03-29 18:03:55 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. PR #29 (feature/p2-config-improvements) fixed Patent.patent_id type annotation from int to str in types.py. Verified: types.py line 7 shows patent_id: str.

Resolved. PR #29 (feature/p2-config-improvements) fixed Patent.patent_id type annotation from int to str in types.py. Verified: types.py line 7 shows patent_id: str.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1027
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?