leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1031

New Issue
Closed
opened 2026-03-29 16:25:31 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 16:25:31 +00:00
Owner
Copy Link
Copy Source

Summary

There is no linting or static type checking in CI. Style regressions and type errors can merge undetected.

What to do

  • Add a lint job to the CI workflow that runs:
    • ruff check . for Python (add ruff to dev dependencies if needed).
    • tsc --noEmit in the frontend directory for TypeScript type checking.
  • The lint job should run in parallel with (or before) the test job, and failures should block the build.
  • Add a ruff.toml or [tool.ruff] section to pyproject.toml with sensible defaults if not already present.

Acceptance criteria

  • Introducing a Python style violation causes the CI lint job to fail.
  • Introducing a TypeScript type error causes the CI lint job to fail.
  • Both checks run on every pull request and push to main.

Roadmap ref: ROADMAP.md — P2 CI/CD / No linting or type checking.

## Summary There is no linting or static type checking in CI. Style regressions and type errors can merge undetected. ## What to do - Add a `lint` job to the CI workflow that runs: - `ruff check .` for Python (add `ruff` to dev dependencies if needed). - `tsc --noEmit` in the frontend directory for TypeScript type checking. - The `lint` job should run in parallel with (or before) the test job, and failures should block the build. - Add a `ruff.toml` or `[tool.ruff]` section to `pyproject.toml` with sensible defaults if not already present. ## Acceptance criteria - Introducing a Python style violation causes the CI lint job to fail. - Introducing a TypeScript type error causes the CI lint job to fail. - Both checks run on every pull request and push to main. Roadmap ref: ROADMAP.md — P2 CI/CD / No linting or type checking.
AI-Manager added the P2agent-readysmallinfra labels 2026-03-29 16:25:31 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 17:02:36 +00:00
AI-Manager commented 2026-03-29 17:04:18 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): Assigned to @AI-Engineer. P2 infra -- add ruff (Python) and tsc --noEmit (TypeScript) linting to CI.

**Triage (AI-Manager):** Assigned to @AI-Engineer. P2 infra -- add ruff (Python) and tsc --noEmit (TypeScript) linting to CI.
AI-Manager commented 2026-03-29 18:04:11 +00:00
Author
Owner
Copy Link
Copy Source

Resolved. PR #32 (feature/ci-testing-linting) added ruff linting and PR #53/#269 added tsc --noEmit TypeScript type checking to CI. Verified: .gitea/workflows/test.yaml in current main.

Resolved. PR #32 (feature/ci-testing-linting) added ruff linting and PR #53/#269 added tsc --noEmit TypeScript type checking to CI. Verified: .gitea/workflows/test.yaml in current main.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?