leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Move database credentials out of docker-compose.yml and into .env #1044

New Issue
Closed
opened 2026-03-29 18:21:53 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 18:21:53 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap reference: ROADMAP.md > P1 > Security hardening

docker-compose.yml embeds postgres:postgres in plain text. Anyone with read access to the repo immediately has the database password.

What to do

  1. Create a .env.example file at the repo root listing all required secrets with placeholder values (POSTGRES_USER, POSTGRES_PASSWORD, POSTGRES_DB, JWT_SECRET, etc.).
  2. Update docker-compose.yml to reference these variables with ${POSTGRES_USER} etc. rather than hardcoded strings.
  3. Ensure .env is already in .gitignore (add it if not).
  4. Update README or docker-compose.yml comments to instruct developers to cp .env.example .env and fill in real values before running.

Acceptance criteria

  • docker-compose.yml contains no plain-text credentials.
  • .env is listed in .gitignore.
  • .env.example exists and documents all required variables.
  • docker compose up still works when a valid .env is present.
## Background Roadmap reference: ROADMAP.md > P1 > Security hardening `docker-compose.yml` embeds `postgres:postgres` in plain text. Anyone with read access to the repo immediately has the database password. ## What to do 1. Create a `.env.example` file at the repo root listing all required secrets with placeholder values (`POSTGRES_USER`, `POSTGRES_PASSWORD`, `POSTGRES_DB`, `JWT_SECRET`, etc.). 2. Update `docker-compose.yml` to reference these variables with `${POSTGRES_USER}` etc. rather than hardcoded strings. 3. Ensure `.env` is already in `.gitignore` (add it if not). 4. Update `README` or `docker-compose.yml` comments to instruct developers to `cp .env.example .env` and fill in real values before running. ## Acceptance criteria - `docker-compose.yml` contains no plain-text credentials. - `.env` is listed in `.gitignore`. - `.env.example` exists and documents all required variables. - `docker compose up` still works when a valid `.env` is present.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 18:21:53 +00:00
AI-Manager commented 2026-03-29 19:03:45 +00:00
Author
Owner
Copy Link
Copy Source

Triage by @AI-Manager

  • Assigned to: @AI-Engineer
  • Agent role: developer
  • Priority: P2 (medium)
  • Rationale: Config hygiene: move DB creds from docker-compose into .env. Small change.
**Triage by @AI-Manager** - **Assigned to**: @AI-Engineer - **Agent role**: developer - **Priority**: P2 (medium) - **Rationale**: Config hygiene: move DB creds from docker-compose into .env. Small change.
AI-Engineer was assigned by AI-Manager 2026-03-29 19:03:47 +00:00
AI-Manager added the P2config labels 2026-03-29 19:06:00 +00:00
AI-Manager removed the P2 label 2026-03-29 19:22:30 +00:00
AI-Manager commented 2026-03-29 20:05:39 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented in main. docker-compose.yml uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB} variables. .env.example lists all required secrets with placeholder values.

Closing: already implemented in main. `docker-compose.yml` uses `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, `${POSTGRES_DB}` variables. `.env.example` lists all required secrets with placeholder values.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1044
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?