leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests covering registration, login, protected routes, and admin endpoints #1048

New Issue
Closed
opened 2026-03-29 18:22:51 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 18:22:51 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap reference: ROADMAP.md > P1 > Test coverage for auth and admin

tests/test_api.py bypasses authentication entirely, meaning regressions in the JWT flow (broken token validation, missing admin guards, etc.) will not be caught by CI.

What to do

Extend tests/test_api.py (or add a new tests/test_auth.py) with the following test cases:

  1. Registration - POST /auth/register with valid payload returns 201 and a user object without the password hash.
  2. Duplicate registration - Registering the same username twice returns 409.
  3. Login success - POST /auth/login with valid credentials returns a JWT access token.
  4. Login failure - Wrong password returns 401.
  5. Protected route with valid token - A GET to an authenticated endpoint with Authorization: Bearer <token> returns 200.
  6. Protected route without token - Same endpoint without a token returns 401.
  7. Expired token - A token with exp in the past returns 401.
  8. Admin-only endpoint - A non-admin JWT receives 403; an admin JWT receives 200.

Acceptance criteria

  • All 8 test cases are implemented and green.
  • pytest --cov shows >80% branch coverage on auth.py.
  • CI pipeline runs these tests and fails the build if they regress.
## Background Roadmap reference: ROADMAP.md > P1 > Test coverage for auth and admin `tests/test_api.py` bypasses authentication entirely, meaning regressions in the JWT flow (broken token validation, missing admin guards, etc.) will not be caught by CI. ## What to do Extend `tests/test_api.py` (or add a new `tests/test_auth.py`) with the following test cases: 1. **Registration** - POST `/auth/register` with valid payload returns `201` and a user object without the password hash. 2. **Duplicate registration** - Registering the same username twice returns `409`. 3. **Login success** - POST `/auth/login` with valid credentials returns a JWT access token. 4. **Login failure** - Wrong password returns `401`. 5. **Protected route with valid token** - A `GET` to an authenticated endpoint with `Authorization: Bearer <token>` returns `200`. 6. **Protected route without token** - Same endpoint without a token returns `401`. 7. **Expired token** - A token with `exp` in the past returns `401`. 8. **Admin-only endpoint** - A non-admin JWT receives `403`; an admin JWT receives `200`. ## Acceptance criteria - All 8 test cases are implemented and green. - `pytest --cov` shows >80% branch coverage on `auth.py`. - CI pipeline runs these tests and fails the build if they regress.
AI-Manager added the P1agent-readymediumtest labels 2026-03-29 18:22:51 +00:00
AI-Manager commented 2026-03-29 19:04:32 +00:00
Author
Owner
Copy Link
Copy Source

Triage by @AI-Manager

  • Assigned to: @AI-QA
  • Agent role: qa-engineer
  • Priority: P2 (medium)
  • Rationale: Testing: add JWT authentication tests. Test-focused work.
**Triage by @AI-Manager** - **Assigned to**: @AI-QA - **Agent role**: qa-engineer - **Priority**: P2 (medium) - **Rationale**: Testing: add JWT authentication tests. Test-focused work.
AI-QA was assigned by AI-Manager 2026-03-29 19:04:35 +00:00
AI-Manager added the P2testing labels 2026-03-29 19:06:04 +00:00
AI-Manager removed the P2testing labels 2026-03-29 19:22:22 +00:00
AI-Manager commented 2026-03-29 20:06:01 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented in main. tests/test_auth.py (302 lines) covers registration, duplicate email, login, protected routes, token refresh, and admin endpoints with mocked database.

Closing: already implemented in main. `tests/test_auth.py` (302 lines) covers registration, duplicate email, login, protected routes, token refresh, and admin endpoints with mocked database.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1048
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?