leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls in analyzer.py, serp_api.py, and llm.py with structured logging #1049

New Issue
Closed
opened 2026-03-29 18:23:08 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 18:23:08 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap reference: ROADMAP.md > P2 > Backend > Add structured logging

analyzer.py, serp_api.py, and llm.py use ad-hoc print() statements for debug output. This makes it impossible to filter by log level, route logs to an aggregator, or suppress noise in tests.

What to do

  1. Add a logging setup module (or configure in api.py startup) that sets format, level, and optionally JSON output.
  2. Replace all print() calls in the three files with appropriate logging.info(), logging.debug(), logging.warning(), or logging.error() calls.
  3. Accept a LOG_LEVEL environment variable (default INFO) to control verbosity at runtime.
  4. Ensure test output is not polluted by log messages at INFO level (configure caplog or set level to WARNING in pytest config).

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • LOG_LEVEL=DEBUG surfaces debug messages; LOG_LEVEL=WARNING suppresses info messages.
  • pytest output is clean by default.
## Background Roadmap reference: ROADMAP.md > P2 > Backend > Add structured logging `analyzer.py`, `serp_api.py`, and `llm.py` use ad-hoc `print()` statements for debug output. This makes it impossible to filter by log level, route logs to an aggregator, or suppress noise in tests. ## What to do 1. Add a `logging` setup module (or configure in `api.py` startup) that sets format, level, and optionally JSON output. 2. Replace all `print()` calls in the three files with appropriate `logging.info()`, `logging.debug()`, `logging.warning()`, or `logging.error()` calls. 3. Accept a `LOG_LEVEL` environment variable (default `INFO`) to control verbosity at runtime. 4. Ensure test output is not polluted by log messages at INFO level (configure `caplog` or set level to WARNING in pytest config). ## Acceptance criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - `LOG_LEVEL=DEBUG` surfaces debug messages; `LOG_LEVEL=WARNING` suppresses info messages. - `pytest` output is clean by default.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-29 18:23:08 +00:00
AI-Manager commented 2026-03-29 19:03:57 +00:00
Author
Owner
Copy Link
Copy Source

Triage by @AI-Manager

  • Assigned to: @AI-Engineer
  • Agent role: developer
  • Priority: P2 (medium)
  • Rationale: Code quality: replace print() with structured logging across backend.
**Triage by @AI-Manager** - **Assigned to**: @AI-Engineer - **Agent role**: developer - **Priority**: P2 (medium) - **Rationale**: Code quality: replace print() with structured logging across backend.
AI-Engineer was assigned by AI-Manager 2026-03-29 19:03:59 +00:00
AI-Manager added the feature label 2026-03-29 19:06:06 +00:00
AI-Manager commented 2026-03-29 20:06:18 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented in main. All print() calls in analyzer.py, serp_api.py, and llm.py have been replaced with logging.getLogger(__name__). config.py sets up logging with configurable LOG_LEVEL env var.

Closing: already implemented in main. All `print()` calls in `analyzer.py`, `serp_api.py`, and `llm.py` have been replaced with `logging.getLogger(__name__)`. `config.py` sets up logging with configurable `LOG_LEVEL` env var.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready feature refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1049
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?