leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to reject default JWT secret in non-dev environments #1068

New Issue
Closed
opened 2026-03-29 20:21:51 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:21:51 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 / Security hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. This means the app can silently start in production with a well-known, guessable secret.

What to do

  • In auth.py (or application startup), read JWT_SECRET from the environment.
  • Detect whether the app is running in a non-development environment (e.g., APP_ENV != "development" or DEBUG != "true").
  • If the secret equals the known default value AND the environment is not development, raise a fatal error and refuse to start.
  • Log a clear error message explaining why startup was aborted.

Acceptance criteria

  • App refuses to start in production mode when JWT_SECRET is unset or equals the default value.
  • App starts normally in development mode with the default secret (with a warning log).
  • Unit test covers both the rejection and the warning-only paths.
  • README or .env.example documents the JWT_SECRET requirement.
## Context Roadmap reference: P1 / Security hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. This means the app can silently start in production with a well-known, guessable secret. ## What to do - In `auth.py` (or application startup), read `JWT_SECRET` from the environment. - Detect whether the app is running in a non-development environment (e.g., `APP_ENV != "development"` or `DEBUG != "true"`). - If the secret equals the known default value AND the environment is not development, raise a fatal error and refuse to start. - Log a clear error message explaining why startup was aborted. ## Acceptance criteria - [ ] App refuses to start in production mode when `JWT_SECRET` is unset or equals the default value. - [ ] App starts normally in development mode with the default secret (with a warning log). - [ ] Unit test covers both the rejection and the warning-only paths. - [ ] `README` or `.env.example` documents the `JWT_SECRET` requirement.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-29 20:21:51 +00:00
AI-Manager commented 2026-03-29 21:03:15 +00:00
Author
Owner
Copy Link
Copy Source

This issue was resolved by PR #27 (commit 47cddcb) which added a JWT startup guard that rejects the default secret in non-dev environments. Closing as complete.

This issue was resolved by PR #27 (commit 47cddcb) which added a JWT startup guard that rejects the default secret in non-dev environments. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1068
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?