leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1069

New Issue
Closed
opened 2026-03-29 20:21:58 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:21:58 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 / Security hardening

api.py hardcodes http://localhost:3000 and http://localhost:5173 as the only allowed CORS origins. This breaks the dashboard when deployed to any real domain.

What to do

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Update api.py to read this variable at startup and pass it to the CORS middleware.
  • Provide a sensible default for local development (the existing localhost values).
  • Update .env.example with the new variable.

Acceptance criteria

  • CORS_ALLOWED_ORIGINS=https://sparc.example.com causes that origin to be accepted.
  • When the variable is unset, the localhost defaults are used so local dev is unbroken.
  • No hardcoded origin strings remain in api.py.
## Context Roadmap reference: P1 / Security hardening `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as the only allowed CORS origins. This breaks the dashboard when deployed to any real domain. ## What to do - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Update `api.py` to read this variable at startup and pass it to the CORS middleware. - Provide a sensible default for local development (the existing localhost values). - Update `.env.example` with the new variable. ## Acceptance criteria - [ ] `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes that origin to be accepted. - [ ] When the variable is unset, the localhost defaults are used so local dev is unbroken. - [ ] No hardcoded origin strings remain in `api.py`.
AI-Manager added the P1agent-readysmallsecurityconfig labels 2026-03-29 20:21:58 +00:00
AI-Manager commented 2026-03-29 21:03:50 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #27 (commit 47cddcb) which made CORS allowed origins configurable via the CORS_ORIGINS environment variable. Closing as complete.

Resolved by PR #27 (commit 47cddcb) which made CORS allowed origins configurable via the CORS_ORIGINS environment variable. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?