leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to reuse a shared pooled DatabaseClient #1071

New Issue
Closed
opened 2026-03-29 20:22:16 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:22:16 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 / Error handling and resilience

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses connection pooling and can exhaust database connections under moderate load.

What to do

  • Refactor auth.py to hold a module-level (or app-state) DatabaseClient instance.
  • Ensure the client is initialised once at startup and reused across all requests.
  • Verify that the existing pooled client pattern used elsewhere in the codebase is followed consistently.

Acceptance criteria

  • get_db_client() no longer creates a new DatabaseClient on every invocation.
  • A single shared client instance is used for all auth database operations.
  • No connection leak occurs under concurrent request load (can be verified by inspection or a basic load test).
## Context Roadmap reference: P1 / Error handling and resilience `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses connection pooling and can exhaust database connections under moderate load. ## What to do - Refactor `auth.py` to hold a module-level (or app-state) `DatabaseClient` instance. - Ensure the client is initialised once at startup and reused across all requests. - Verify that the existing pooled client pattern used elsewhere in the codebase is followed consistently. ## Acceptance criteria - [ ] `get_db_client()` no longer creates a new `DatabaseClient` on every invocation. - [ ] A single shared client instance is used for all auth database operations. - [ ] No connection leak occurs under concurrent request load (can be verified by inspection or a basic load test).
AI-Manager added the P1agent-readysmallbugrefactor labels 2026-03-29 20:22:16 +00:00
AI-Manager commented 2026-03-29 21:04:24 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #30 (commit d366443) which refactored get_db_client() to use a shared pooled DatabaseClient singleton. Closing as complete.

Resolved by PR #30 (commit d366443) which refactored get_db_client() to use a shared pooled DatabaseClient singleton. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?