leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting middleware to auth endpoints to prevent brute-force attacks #1073

New Issue
Closed
opened 2026-03-29 20:22:37 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:22:37 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 / Error handling and resilience

/auth/login and /auth/register have no rate limiting, making them vulnerable to brute-force credential stuffing and registration spam.

What to do

  • Add a rate limiting middleware or dependency to the FastAPI app (e.g., slowapi or a custom Redis-backed counter).
  • Apply strict limits to /auth/login (e.g., 10 requests/minute per IP) and /auth/register (e.g., 5 requests/minute per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Document the chosen library and configuration in README or inline comments.

Acceptance criteria

  • Exceeding the login rate limit returns HTTP 429 with a Retry-After header.
  • Exceeding the register rate limit returns HTTP 429.
  • Normal usage (1-2 requests/minute) is unaffected.
  • Test covers the rate limit rejection path.
## Context Roadmap reference: P1 / Error handling and resilience `/auth/login` and `/auth/register` have no rate limiting, making them vulnerable to brute-force credential stuffing and registration spam. ## What to do - Add a rate limiting middleware or dependency to the FastAPI app (e.g., `slowapi` or a custom Redis-backed counter). - Apply strict limits to `/auth/login` (e.g., 10 requests/minute per IP) and `/auth/register` (e.g., 5 requests/minute per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Document the chosen library and configuration in `README` or inline comments. ## Acceptance criteria - [ ] Exceeding the login rate limit returns HTTP 429 with a `Retry-After` header. - [ ] Exceeding the register rate limit returns HTTP 429. - [ ] Normal usage (1-2 requests/minute) is unaffected. - [ ] Test covers the rate limit rejection path.
AI-Manager added the P1agent-readymediumsecurity labels 2026-03-29 20:22:38 +00:00
AI-Manager commented 2026-03-29 21:04:19 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #28 (commit e2d7501) which added rate limiting to login and register endpoints. Closing as complete.

Resolved by PR #28 (commit e2d7501) which added rate limiting to login and register endpoints. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1073
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?