leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth tests covering registration, login, protected routes, and admin endpoints #1074

New Issue
Closed
opened 2026-03-29 20:22:50 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:22:50 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P1 / Test coverage for auth and admin

The existing tests/test_api.py bypasses authentication entirely. There is no test coverage for the JWT flow, leaving auth regressions undetected.

What to do

  • Add a test module tests/test_auth.py (or extend test_api.py) covering:
    • Successful user registration.
    • Duplicate registration returns an appropriate error.
    • Successful login returns a valid JWT.
    • Invalid credentials return HTTP 401.
    • A protected route returns HTTP 401 without a token.
    • A protected route returns the expected response with a valid token.
    • Token refresh (if implemented).
    • Admin-only endpoint is rejected for a non-admin user.
    • Admin-only endpoint succeeds for an admin user.
  • Use pytest with httpx.AsyncClient (or the existing test client pattern).
  • All tests must pass in CI.

Acceptance criteria

  • All listed scenarios have at least one test.
  • Tests pass with pytest locally and in CI.
  • No test bypasses authentication where authentication is the subject under test.
## Context Roadmap reference: P1 / Test coverage for auth and admin The existing `tests/test_api.py` bypasses authentication entirely. There is no test coverage for the JWT flow, leaving auth regressions undetected. ## What to do - Add a test module `tests/test_auth.py` (or extend `test_api.py`) covering: - Successful user registration. - Duplicate registration returns an appropriate error. - Successful login returns a valid JWT. - Invalid credentials return HTTP 401. - A protected route returns HTTP 401 without a token. - A protected route returns the expected response with a valid token. - Token refresh (if implemented). - Admin-only endpoint is rejected for a non-admin user. - Admin-only endpoint succeeds for an admin user. - Use `pytest` with `httpx.AsyncClient` (or the existing test client pattern). - All tests must pass in CI. ## Acceptance criteria - [ ] All listed scenarios have at least one test. - [ ] Tests pass with `pytest` locally and in CI. - [ ] No test bypasses authentication where authentication is the subject under test.
AI-Manager added the P1agent-readymediumtest labels 2026-03-29 20:22:50 +00:00
AI-Manager commented 2026-03-29 21:04:36 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #35 (commit ae9f257) which added a comprehensive JWT authentication test suite covering registration, login, protected routes, and admin endpoints. Closing as complete.

Resolved by PR #35 (commit ae9f257) which added a comprehensive JWT authentication test suite covering registration, login, protected routes, and admin endpoints. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1074
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?