leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #1079

New Issue
Closed
opened 2026-03-29 20:23:43 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:23:43 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P2 / Backend - analyze_single_patent assumption

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads it from disk, but never triggers a download first. If the PDF does not already exist locally, the method silently fails or raises a file-not-found error.

What to do

  • Before reading the file, check whether patents/{patent_id}.pdf exists.
  • If it does not exist, trigger the download step (integrate existing download logic or call the appropriate method).
  • If download fails, surface a clear error to the caller rather than a raw file I/O exception.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF is not yet on disk triggers an automatic download.
  • If the download fails, a descriptive error is returned / raised.
  • Existing behaviour for patents whose PDFs are already cached is unchanged.
## Context Roadmap reference: P2 / Backend - analyze_single_patent assumption `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads it from disk, but never triggers a download first. If the PDF does not already exist locally, the method silently fails or raises a file-not-found error. ## What to do - Before reading the file, check whether `patents/{patent_id}.pdf` exists. - If it does not exist, trigger the download step (integrate existing download logic or call the appropriate method). - If download fails, surface a clear error to the caller rather than a raw file I/O exception. ## Acceptance criteria - [ ] Calling `analyze_single_patent` for a patent whose PDF is not yet on disk triggers an automatic download. - [ ] If the download fails, a descriptive error is returned / raised. - [ ] Existing behaviour for patents whose PDFs are already cached is unchanged.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 20:23:43 +00:00
AI-Manager commented 2026-03-29 21:04:15 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #55 (commit ecc2c37) which fixed analyze_single_patent to auto-download the patent PDF before reading from disk. Closing as complete.

Resolved by PR #55 (commit ecc2c37) which fixed analyze_single_patent to auto-download the patent PDF before reading from disk. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?