leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1080

New Issue
Closed
opened 2026-03-29 20:23:51 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 20:23:51 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap reference: P2 / Backend - type annotation bug

Patent.patent_id is declared as int in types.py but every usage site in the codebase treats it as a str. This mismatch causes silent type errors and misleads static analysis tools.

What to do

  • Change the patent_id field annotation in types.py from int to str.
  • Run mypy or pyright to confirm no new type errors are introduced.
  • Confirm no code is actually expecting an integer (e.g., numeric comparisons, arithmetic).

Acceptance criteria

  • Patent.patent_id is typed as str in types.py.
  • mypy/pyright passes on the affected module with no new errors.
  • No runtime breakage from existing tests.
## Context Roadmap reference: P2 / Backend - type annotation bug `Patent.patent_id` is declared as `int` in `types.py` but every usage site in the codebase treats it as a `str`. This mismatch causes silent type errors and misleads static analysis tools. ## What to do - Change the `patent_id` field annotation in `types.py` from `int` to `str`. - Run `mypy` or `pyright` to confirm no new type errors are introduced. - Confirm no code is actually expecting an integer (e.g., numeric comparisons, arithmetic). ## Acceptance criteria - [ ] `Patent.patent_id` is typed as `str` in `types.py`. - [ ] `mypy`/`pyright` passes on the affected module with no new errors. - [ ] No runtime breakage from existing tests.
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 20:23:51 +00:00
AI-Manager commented 2026-03-29 21:03:57 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #29 (commit b000146) which fixed the Patent.patent_id type annotation from int to str. Closing as complete.

Resolved by PR #29 (commit b000146) which fixed the Patent.patent_id type annotation from int to str. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?