leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to reuse a shared pooled DatabaseClient #1097

New Issue
Closed
opened 2026-03-29 21:22:31 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 21:22:31 +00:00
Owner
Copy Link
Copy Source

Background

get_db_client() in auth.py instantiates a new DatabaseClient on every call. Because FastAPI dependency injection calls this function for every request that needs a DB, each request opens its own connection, bypassing the connection pool and risking connection exhaustion under any reasonable load.

What to do

  1. Create a module-level singleton DatabaseClient instance (or reuse the one already created in main.py/database.py if one exists).
  2. Make get_db_client() return that singleton rather than creating a new instance.
  3. If the DatabaseClient already uses asyncpg pooling internally, verify the pool is sized appropriately (default min/max).
  4. Add or update a test to verify the same client object is returned on successive calls.

Acceptance criteria

  • get_db_client() returns the same object on repeated calls within the same process.
  • No new DatabaseClient constructor calls appear in auth.py outside of module initialisation.
  • Existing auth tests continue to pass.

Roadmap reference: P1 - Error handling and resilience

## Background `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. Because FastAPI dependency injection calls this function for every request that needs a DB, each request opens its own connection, bypassing the connection pool and risking connection exhaustion under any reasonable load. ## What to do 1. Create a module-level singleton `DatabaseClient` instance (or reuse the one already created in `main.py`/`database.py` if one exists). 2. Make `get_db_client()` return that singleton rather than creating a new instance. 3. If the `DatabaseClient` already uses `asyncpg` pooling internally, verify the pool is sized appropriately (default min/max). 4. Add or update a test to verify the same client object is returned on successive calls. ## Acceptance criteria - [ ] `get_db_client()` returns the same object on repeated calls within the same process. - [ ] No new `DatabaseClient` constructor calls appear in `auth.py` outside of module initialisation. - [ ] Existing auth tests continue to pass. **Roadmap reference:** P1 - Error handling and resilience
AI-Manager added the medium label 2026-03-29 21:22:32 +00:00
AI-Manager added the P1agent-readyrefactor labels 2026-03-29 21:26:28 +00:00
AI-Manager commented 2026-03-29 22:05:28 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been verified as already implemented in the current codebase. The acceptance criteria are met based on code review. Closing as completed.

This issue has been verified as already implemented in the current codebase. The acceptance criteria are met based on code review. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1097
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?