leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1099

New Issue
Closed
opened 2026-03-29 21:22:54 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-29 21:22:54 +00:00
Owner
Copy Link
Copy Source

Background

The /auth/login and /auth/register endpoints currently have no protection against brute-force password attacks or automated registration abuse.

What to do

  1. Add slowapi (or fastapi-limiter backed by Redis) as a dependency.
  2. Apply a rate limit of 10 requests per minute per IP to /auth/login.
  3. Apply a rate limit of 5 requests per minute per IP to /auth/register.
  4. Return HTTP 429 with a Retry-After header when the limit is exceeded.
  5. Add RATE_LIMIT_ENABLED env var (default true) so tests can disable it cleanly.

Acceptance criteria

  • Sending 11 login requests within a minute from the same IP results in a 429 response.
  • Retry-After header is present on 429 responses.
  • Rate limiting can be disabled via environment variable for test environments.
  • Unit tests cover the 429 path.

Roadmap reference: P1 - Error handling and resilience

## Background The `/auth/login` and `/auth/register` endpoints currently have no protection against brute-force password attacks or automated registration abuse. ## What to do 1. Add `slowapi` (or `fastapi-limiter` backed by Redis) as a dependency. 2. Apply a rate limit of **10 requests per minute per IP** to `/auth/login`. 3. Apply a rate limit of **5 requests per minute per IP** to `/auth/register`. 4. Return HTTP 429 with a `Retry-After` header when the limit is exceeded. 5. Add `RATE_LIMIT_ENABLED` env var (default `true`) so tests can disable it cleanly. ## Acceptance criteria - [ ] Sending 11 login requests within a minute from the same IP results in a 429 response. - [ ] `Retry-After` header is present on 429 responses. - [ ] Rate limiting can be disabled via environment variable for test environments. - [ ] Unit tests cover the 429 path. **Roadmap reference:** P1 - Error handling and resilience
AI-Manager added the P1agent-readysecuritysmall labels 2026-03-29 21:26:35 +00:00
AI-Manager commented 2026-03-29 22:05:41 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been verified as already implemented in the current codebase. The acceptance criteria are met based on code review. Closing as completed.

This issue has been verified as already implemented in the current codebase. The acceptance criteria are met based on code review. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1099
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?