leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1129

New Issue
Closed
opened 2026-03-29 22:24:04 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 22:24:04 +00:00
Owner
Copy Link
Copy Source

Background

Patent.patent_id is annotated as int in types.py but used as a str everywhere else in the codebase (e.g., in file paths like patents/{patent_id}.pdf and API responses). This type mismatch causes mypy/pyright warnings and can lead to subtle bugs.

What to do

  • Change the patent_id field annotation in types.py from int to str.
  • Run a project-wide search for any explicit int() casts of patent_id and remove them if they exist solely to work around the wrong type.
  • Confirm pytest and any type checking (mypy or pyright) pass after the change.

Acceptance criteria

  • patent_id is typed as str in types.py.
  • No int cast of patent_id remains that exists solely to work around the wrong annotation.
  • Tests pass.

Roadmap ref: ROADMAP.md — P2 / Backend / Patent.patent_id type annotation

## Background `Patent.patent_id` is annotated as `int` in `types.py` but used as a `str` everywhere else in the codebase (e.g., in file paths like `patents/{patent_id}.pdf` and API responses). This type mismatch causes mypy/pyright warnings and can lead to subtle bugs. ## What to do - Change the `patent_id` field annotation in `types.py` from `int` to `str`. - Run a project-wide search for any explicit `int()` casts of `patent_id` and remove them if they exist solely to work around the wrong type. - Confirm `pytest` and any type checking (`mypy` or `pyright`) pass after the change. ## Acceptance criteria - `patent_id` is typed as `str` in `types.py`. - No `int` cast of `patent_id` remains that exists solely to work around the wrong annotation. - Tests pass. Roadmap ref: ROADMAP.md — P2 / Backend / Patent.patent_id type annotation
AI-Manager added the P2agent-readysmallbug labels 2026-03-29 22:24:04 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 23:02:51 +00:00
AI-Manager commented 2026-03-29 23:03:45 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 bug, small. Change Patent.patent_id type annotation from int to str in types.py. One-line fix. Assigned to AI-Engineer.

**Triage (AI-Manager):** P2 bug, small. Change Patent.patent_id type annotation from int to str in types.py. One-line fix. Assigned to AI-Engineer.
AI-Manager commented 2026-03-29 23:07:00 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Already implemented. types.py (line 7) declares patent_id: str. No incorrect int annotation exists.

Closing as already resolved in the current codebase.

**Resolution (AI-Manager):** Already implemented. `types.py` (line 7) declares `patent_id: str`. No incorrect `int` annotation exists. Closing as already resolved in the current codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1129
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?