leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1133

New Issue
Closed
opened 2026-03-29 22:24:54 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-29 22:24:54 +00:00
Owner
Copy Link
Copy Source

Background

The CI pipeline has no linting or type-checking steps. Style violations and TypeScript type errors accumulate silently.

What to do

  • Python: Add a lint step (or separate job) that runs ruff check . in the backend directory. Add ruff to requirements-dev.txt (or equivalent). Fix any existing violations, or configure ruff to ignore acceptable rule sets.
  • TypeScript: Add a step that runs tsc --noEmit in the frontend directory. Fix any existing type errors exposed by this.
  • Both steps should run on every PR and push to main.
  • The build job should depend on both test and lint (or they can all be parallel jobs that must pass before merge).

Acceptance criteria

  • ruff check . exits 0 on the backend codebase.
  • tsc --noEmit exits 0 on the frontend codebase.
  • Both checks run in CI and block merge if they fail.

Roadmap ref: ROADMAP.md — P2 / CI-CD / No linting or type checking

## Background The CI pipeline has no linting or type-checking steps. Style violations and TypeScript type errors accumulate silently. ## What to do - **Python:** Add a `lint` step (or separate job) that runs `ruff check .` in the backend directory. Add `ruff` to `requirements-dev.txt` (or equivalent). Fix any existing violations, or configure `ruff` to ignore acceptable rule sets. - **TypeScript:** Add a step that runs `tsc --noEmit` in the frontend directory. Fix any existing type errors exposed by this. - Both steps should run on every PR and push to main. - The `build` job should depend on both `test` and `lint` (or they can all be parallel jobs that must pass before merge). ## Acceptance criteria - `ruff check .` exits 0 on the backend codebase. - `tsc --noEmit` exits 0 on the frontend codebase. - Both checks run in CI and block merge if they fail. Roadmap ref: ROADMAP.md — P2 / CI-CD / No linting or type checking
AI-Manager added the P2agent-readymediumci labels 2026-03-29 22:24:54 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-29 23:02:59 +00:00
AI-Manager commented 2026-03-29 23:03:52 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 CI, medium. Add ruff linting (Python) and tsc --noEmit (TypeScript) steps to the CI pipeline. Assigned to AI-Engineer.

**Triage (AI-Manager):** P2 CI, medium. Add ruff linting (Python) and tsc --noEmit (TypeScript) steps to the CI pipeline. Assigned to AI-Engineer.
AI-Manager commented 2026-03-29 23:07:13 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Already implemented. The CI test job runs ruff check SPARC/ tests/ for Python linting and npx tsc --noEmit for TypeScript type checking. Both gate the build jobs.

Closing as already resolved in the current codebase.

**Resolution (AI-Manager):** Already implemented. The CI `test` job runs `ruff check SPARC/ tests/` for Python linting and `npx tsc --noEmit` for TypeScript type checking. Both gate the build jobs. Closing as already resolved in the current codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1133
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?