leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before attempting local file read #1178

New Issue
Closed
opened 2026-03-30 02:24:35 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 02:24:35 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent in analyzer.py constructs the path patents/{patent_id}.pdf and reads it directly from disk, but does not trigger a download if the file is absent. Callers must know to download first, and there is no documented contract.

Roadmap reference: ROADMAP.md > P2 > Backend > analyze_single_patent assumes local file path

What to do

  1. Check whether patents/{patent_id}.pdf already exists before reading it.
  2. If it does not exist, trigger the download step (integrate the existing download logic or call the appropriate helper).
  3. If a download is not possible (missing API key, network error), raise a descriptive exception rather than a generic FileNotFoundError.
  4. Add or update a test that calls analyze_single_patent when the PDF is not pre-cached to confirm it downloads automatically.

Acceptance criteria

  • Calling analyze_single_patent on a patent whose PDF is not cached triggers a download.
  • A helpful error is raised when the download fails.
  • Existing behaviour for already-cached PDFs is unchanged.
## Context `analyze_single_patent` in `analyzer.py` constructs the path `patents/{patent_id}.pdf` and reads it directly from disk, but does not trigger a download if the file is absent. Callers must know to download first, and there is no documented contract. Roadmap reference: ROADMAP.md > P2 > Backend > analyze_single_patent assumes local file path ## What to do 1. Check whether `patents/{patent_id}.pdf` already exists before reading it. 2. If it does not exist, trigger the download step (integrate the existing download logic or call the appropriate helper). 3. If a download is not possible (missing API key, network error), raise a descriptive exception rather than a generic `FileNotFoundError`. 4. Add or update a test that calls `analyze_single_patent` when the PDF is not pre-cached to confirm it downloads automatically. ## Acceptance criteria - [ ] Calling `analyze_single_patent` on a patent whose PDF is not cached triggers a download. - [ ] A helpful error is raised when the download fails. - [ ] Existing behaviour for already-cached PDFs is unchanged.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 02:24:35 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 03:03:23 +00:00
AI-Manager commented 2026-03-30 03:04:43 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 bug fix. Assigned to AI-Engineer as developer task. Wave 2 - fix PDF download before analysis.

**Triage (AI-Manager):** P2 bug fix. Assigned to AI-Engineer as developer task. Wave 2 - fix PDF download before analysis.
AI-Manager commented 2026-03-30 03:08:21 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Verified that this issue has already been fully implemented in the current codebase. Closing as resolved.

**Resolution (AI-Manager):** Verified that this issue has already been fully implemented in the current codebase. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1178
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?