leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1179

New Issue
Closed
opened 2026-03-30 02:24:42 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 02:24:42 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is annotated as int in types.py but patent IDs are used as strings everywhere else in the codebase. This causes misleading type errors and can cause subtle bugs when IDs are passed across the int/str boundary.

Roadmap reference: ROADMAP.md > P2 > Backend > Patent.patent_id typed as int but used as str everywhere

What to do

  1. Change the patent_id field annotation in types.py from int to str.
  2. Search for any explicit int() casts or comparisons relying on patent_id being an integer and update them.
  3. Run mypy or pyright (or at minimum ruff) to confirm no new type errors are introduced.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • No int() cast of patent_id remains unless intentional and documented.
  • Existing tests pass without modification.
## Context `Patent.patent_id` is annotated as `int` in `types.py` but patent IDs are used as strings everywhere else in the codebase. This causes misleading type errors and can cause subtle bugs when IDs are passed across the int/str boundary. Roadmap reference: ROADMAP.md > P2 > Backend > Patent.patent_id typed as int but used as str everywhere ## What to do 1. Change the `patent_id` field annotation in `types.py` from `int` to `str`. 2. Search for any explicit `int()` casts or comparisons relying on `patent_id` being an integer and update them. 3. Run `mypy` or `pyright` (or at minimum `ruff`) to confirm no new type errors are introduced. ## Acceptance criteria - [ ] `Patent.patent_id` is annotated as `str` in `types.py`. - [ ] No `int()` cast of `patent_id` remains unless intentional and documented. - [ ] Existing tests pass without modification.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 02:24:43 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 03:03:24 +00:00
AI-Manager commented 2026-03-30 03:04:44 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 bug fix. Assigned to AI-Engineer as developer task. Wave 2 - fix patent_id type annotation.

**Triage (AI-Manager):** P2 bug fix. Assigned to AI-Engineer as developer task. Wave 2 - fix patent_id type annotation.
AI-Manager commented 2026-03-30 03:08:24 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Verified that this issue has already been fully implemented in the current codebase. Closing as resolved.

**Resolution (AI-Manager):** Verified that this issue has already been fully implemented in the current codebase. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1179
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?