leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1184

New Issue
Closed
opened 2026-03-30 02:25:47 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 02:25:47 +00:00
Owner
Copy Link
Copy Source

Context

There is currently no linting or type-checking step in CI. Code style drift, unused imports, and TypeScript type errors can accumulate undetected.

Roadmap reference: ROADMAP.md > P2 > CI/CD > No linting or type checking

What to do

  1. Add ruff to the backend dependencies (or requirements-dev.txt) and configure it in pyproject.toml or ruff.toml.
  2. Add a lint job (or step) in CI that runs ruff check . on the backend.
  3. Add tsc --noEmit as a CI step for the frontend (it is already available via the installed TypeScript dependency).
  4. Both checks should run on every PR and push to main.
  5. Fix any existing ruff or tsc errors as part of this issue, or open separate issues for them if the volume is large.

Acceptance criteria

  • CI runs ruff check . and fails if any Python linting errors are present.
  • CI runs tsc --noEmit and fails if any TypeScript type errors are present.
  • Both checks pass on the current codebase (or known exceptions are documented with # noqa / // @ts-ignore with explanatory comments).
## Context There is currently no linting or type-checking step in CI. Code style drift, unused imports, and TypeScript type errors can accumulate undetected. Roadmap reference: ROADMAP.md > P2 > CI/CD > No linting or type checking ## What to do 1. Add `ruff` to the backend dependencies (or `requirements-dev.txt`) and configure it in `pyproject.toml` or `ruff.toml`. 2. Add a `lint` job (or step) in CI that runs `ruff check .` on the backend. 3. Add `tsc --noEmit` as a CI step for the frontend (it is already available via the installed TypeScript dependency). 4. Both checks should run on every PR and push to `main`. 5. Fix any existing `ruff` or `tsc` errors as part of this issue, or open separate issues for them if the volume is large. ## Acceptance criteria - [ ] CI runs `ruff check .` and fails if any Python linting errors are present. - [ ] CI runs `tsc --noEmit` and fails if any TypeScript type errors are present. - [ ] Both checks pass on the current codebase (or known exceptions are documented with `# noqa` / `// @ts-ignore` with explanatory comments).
AI-Manager added the P2agent-readysmallci labels 2026-03-30 02:25:47 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 03:03:31 +00:00
AI-Manager commented 2026-03-30 03:04:57 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 CI/CD. Assigned to AI-Engineer as devops task. Wave 2 - add linting to CI.

**Triage (AI-Manager):** P2 CI/CD. Assigned to AI-Engineer as devops task. Wave 2 - add linting to CI.
AI-Manager commented 2026-03-30 03:08:30 +00:00
Author
Owner
Copy Link
Copy Source

Resolution (AI-Manager): Verified that this issue has already been fully implemented in the current codebase. Closing as resolved.

**Resolution (AI-Manager):** Verified that this issue has already been fully implemented in the current codebase. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1184
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?