leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to reuse a shared pooled DatabaseClient #119

New Issue
Closed
opened 2026-03-26 16:22:08 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:22:08 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py currently instantiates a new DatabaseClient on every invocation. This bypasses connection pooling and will exhaust available database connections under moderate load.

Work

  • Refactor auth.py so DatabaseClient is created once (e.g., as a module-level singleton or via FastAPI dependency injection with a lifespan-managed instance).
  • Ensure the same pooled client is used by all auth-related route handlers.
  • Verify no other modules exhibit the same pattern and fix if found.
  • Add a test (or update an existing one) that confirms only a single client instance is created across multiple auth requests.

Acceptance Criteria

  • A single DatabaseClient instance is shared across all calls within a process lifetime.
  • Load test or unit test demonstrates no connection leak under repeated auth calls.
  • No regressions in existing auth route tests.

References

Roadmap: P1 — Error handling and resilience — get_db_client() connection pool.

## Context `get_db_client()` in `auth.py` currently instantiates a new `DatabaseClient` on every invocation. This bypasses connection pooling and will exhaust available database connections under moderate load. ## Work - Refactor `auth.py` so `DatabaseClient` is created once (e.g., as a module-level singleton or via FastAPI dependency injection with a lifespan-managed instance). - Ensure the same pooled client is used by all auth-related route handlers. - Verify no other modules exhibit the same pattern and fix if found. - Add a test (or update an existing one) that confirms only a single client instance is created across multiple auth requests. ## Acceptance Criteria - A single `DatabaseClient` instance is shared across all calls within a process lifetime. - Load test or unit test demonstrates no connection leak under repeated auth calls. - No regressions in existing auth route tests. ## References Roadmap: P1 — Error handling and resilience — get_db_client() connection pool.
AI-Manager added the P1agent-readymedium labels 2026-03-26 16:22:08 +00:00
AI-Manager commented 2026-03-26 17:02:59 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. SPARC/auth.py now uses a shared pooled DatabaseClient singleton (_db_client) initialized at startup via init_db_client() and cleaned up via close_db_client(), instead of creating a new instance per call.

Resolved by PR #30 ("refactor(db): shared pooled DatabaseClient singleton"). Closing.

This issue has already been resolved. `SPARC/auth.py` now uses a shared pooled `DatabaseClient` singleton (`_db_client`) initialized at startup via `init_db_client()` and cleaned up via `close_db_client()`, instead of creating a new instance per call. Resolved by PR #30 ("refactor(db): shared pooled DatabaseClient singleton"). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?