leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Remove hardcoded database credentials from docker-compose.yml #1195

New Issue
Closed
opened 2026-03-30 04:22:09 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 04:22:09 +00:00
Owner
Copy Link
Copy Source

Context

docker-compose.yml embeds POSTGRES_USER=postgres and POSTGRES_PASSWORD=postgres in plain text. Anyone who clones the repository has these credentials, and they are likely reused in deployments.

Roadmap reference: ROADMAP.md > P1 > Security hardening > Database credentials in docker-compose.yml

What to do

  1. Replace the hardcoded credential values in docker-compose.yml with variable references (e.g., ${POSTGRES_PASSWORD}).
  2. Add a .env.example file with placeholder values and instructions.
  3. Ensure .env is already in .gitignore; add it if not.
  4. Update the README quickstart section to explain copying .env.example to .env.

Acceptance criteria

  • docker-compose.yml contains no hardcoded password strings.
  • docker-compose up works correctly when .env is populated from .env.example.
  • .env is listed in .gitignore.
## Context `docker-compose.yml` embeds `POSTGRES_USER=postgres` and `POSTGRES_PASSWORD=postgres` in plain text. Anyone who clones the repository has these credentials, and they are likely reused in deployments. Roadmap reference: ROADMAP.md > P1 > Security hardening > Database credentials in docker-compose.yml ## What to do 1. Replace the hardcoded credential values in `docker-compose.yml` with variable references (e.g., `${POSTGRES_PASSWORD}`). 2. Add a `.env.example` file with placeholder values and instructions. 3. Ensure `.env` is already in `.gitignore`; add it if not. 4. Update the README quickstart section to explain copying `.env.example` to `.env`. ## Acceptance criteria - [ ] `docker-compose.yml` contains no hardcoded password strings. - [ ] `docker-compose up` works correctly when `.env` is populated from `.env.example`. - [ ] `.env` is listed in `.gitignore`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 04:22:09 +00:00
AI-Manager commented 2026-03-30 05:04:28 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved on main. docker-compose.yml uses environment variable substitution (${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB}) instead of hardcoded credentials. Closing as complete.

This issue has been resolved on main. `docker-compose.yml` uses environment variable substitution (`${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, `${POSTGRES_DB}`) instead of hardcoded credentials. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?