leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared connection pool #1196

New Issue
Closed
opened 2026-03-30 04:22:20 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 04:22:20 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py instantiates a new DatabaseClient on every call. Under concurrent load this bypasses the connection pool and can exhaust available database connections, causing 500 errors.

Roadmap reference: ROADMAP.md > P1 > Error handling and resilience > get_db_client() creates a new DatabaseClient on every call

What to do

  1. Create a single application-level DatabaseClient instance (e.g., as a FastAPI dependency or module-level singleton).
  2. Update auth.py and any other callers that instantiate their own DatabaseClient to use the shared instance.
  3. Ensure the shared client is properly initialized at startup and closed on shutdown using FastAPI lifespan events.

Acceptance criteria

  • A single DatabaseClient instance is shared across all auth requests.
  • No new DatabaseClient objects are created per-request in auth.py.
  • A load test (or code inspection) confirms the connection pool is respected.
## Context `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. Under concurrent load this bypasses the connection pool and can exhaust available database connections, causing 500 errors. Roadmap reference: ROADMAP.md > P1 > Error handling and resilience > get_db_client() creates a new DatabaseClient on every call ## What to do 1. Create a single application-level `DatabaseClient` instance (e.g., as a FastAPI dependency or module-level singleton). 2. Update `auth.py` and any other callers that instantiate their own `DatabaseClient` to use the shared instance. 3. Ensure the shared client is properly initialized at startup and closed on shutdown using FastAPI lifespan events. ## Acceptance criteria - [ ] A single `DatabaseClient` instance is shared across all auth requests. - [ ] No new `DatabaseClient` objects are created per-request in `auth.py`. - [ ] A load test (or code inspection) confirms the connection pool is respected.
AI-Manager added the P1agent-readymediumbug-fix labels 2026-03-30 04:22:20 +00:00
AI-Manager commented 2026-03-30 05:04:31 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved on main. SPARC/auth.py (lines 149-178) implements a module-level singleton DatabaseClient initialized via init_db_client() at startup and accessed through get_db_client(), replacing per-call instantiation. Closing as complete.

This issue has been resolved on main. `SPARC/auth.py` (lines 149-178) implements a module-level singleton `DatabaseClient` initialized via `init_db_client()` at startup and accessed through `get_db_client()`, replacing per-call instantiation. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug-fix medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1196
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?