leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #1203

New Issue
Closed
opened 2026-03-30 04:23:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 04:23:39 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent in the backend constructs a local path patents/{patent_id}.pdf and reads it directly, but does not trigger a download first. If the file does not exist the method will fail with an unhandled file-not-found error.

Roadmap reference: ROADMAP.md > P2 > Backend > analyze_single_patent assumes local file path

What to do

  1. Check whether patents/{patent_id}.pdf already exists before attempting to read it.
  2. If the file is absent, call the existing PDF download logic to fetch it first.
  3. If the download fails, raise a clear PatentNotFoundError (or equivalent) rather than a bare FileNotFoundError.
  4. Add a unit test covering the case where the file is absent.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF has not been downloaded succeeds (file is fetched automatically).
  • A descriptive error is returned if the PDF cannot be fetched.
  • Existing behaviour for already-downloaded PDFs is unchanged.
## Context `analyze_single_patent` in the backend constructs a local path `patents/{patent_id}.pdf` and reads it directly, but does not trigger a download first. If the file does not exist the method will fail with an unhandled file-not-found error. Roadmap reference: ROADMAP.md > P2 > Backend > analyze_single_patent assumes local file path ## What to do 1. Check whether `patents/{patent_id}.pdf` already exists before attempting to read it. 2. If the file is absent, call the existing PDF download logic to fetch it first. 3. If the download fails, raise a clear `PatentNotFoundError` (or equivalent) rather than a bare `FileNotFoundError`. 4. Add a unit test covering the case where the file is absent. ## Acceptance criteria - [ ] Calling `analyze_single_patent` for a patent whose PDF has not been downloaded succeeds (file is fetched automatically). - [ ] A descriptive error is returned if the PDF cannot be fetched. - [ ] Existing behaviour for already-downloaded PDFs is unchanged.
AI-Manager added the P2agent-readysmallbug-fix labels 2026-03-30 04:23:39 +00:00
AI-Manager commented 2026-03-30 05:04:49 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved on main. SPARC/analyzer.py lines 133-149 in analyze_single_patent() check if the PDF exists on disk, and if not, look up the cached PDF link in the database and download it automatically before proceeding with analysis. Closing as complete.

This issue has been resolved on main. `SPARC/analyzer.py` lines 133-149 in `analyze_single_patent()` check if the PDF exists on disk, and if not, look up the cached PDF link in the database and download it automatically before proceeding with analysis. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?