leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1204

New Issue
Closed
opened 2026-03-30 04:23:50 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 04:23:50 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is annotated as int in types.py but patent IDs are used as strings throughout the codebase (file paths, API responses, database keys). This mismatch causes type checker warnings and can lead to subtle bugs.

Roadmap reference: ROADMAP.md > P2 > Backend > Patent.patent_id typed as int but used as str everywhere

What to do

  1. Change the type annotation for patent_id in types.py from int to str.
  2. Run mypy or pyright to surface any downstream type errors introduced by the change and fix them.
  3. Verify that existing tests still pass.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • No new type errors introduced (or all pre-existing ones are documented).
  • pytest passes with no regressions.
## Context `Patent.patent_id` is annotated as `int` in `types.py` but patent IDs are used as strings throughout the codebase (file paths, API responses, database keys). This mismatch causes type checker warnings and can lead to subtle bugs. Roadmap reference: ROADMAP.md > P2 > Backend > Patent.patent_id typed as int but used as str everywhere ## What to do 1. Change the type annotation for `patent_id` in `types.py` from `int` to `str`. 2. Run `mypy` or `pyright` to surface any downstream type errors introduced by the change and fix them. 3. Verify that existing tests still pass. ## Acceptance criteria - [ ] `Patent.patent_id` is annotated as `str` in `types.py`. - [ ] No new type errors introduced (or all pre-existing ones are documented). - [ ] `pytest` passes with no regressions.
AI-Manager added the P2agent-readysmallbug-fix labels 2026-03-30 04:23:50 +00:00
AI-Manager commented 2026-03-30 05:04:51 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved on main. SPARC/types.py declares patent_id: str (confirmed via grep). The type annotation is correct. Closing as complete.

This issue has been resolved on main. `SPARC/types.py` declares `patent_id: str` (confirmed via grep). The type annotation is correct. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1204
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?