leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1208

New Issue
Closed
opened 2026-03-30 04:24:38 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 04:24:38 +00:00
Owner
Copy Link
Copy Source

Context

There is no linting or type-checking step in CI. Style issues and TypeScript type errors can be merged undetected.

Roadmap reference: ROADMAP.md > P2 > CI/CD > No linting or type checking

What to do

  1. Add ruff to the Python dev dependencies and configure it in pyproject.toml (or ruff.toml).
  2. Add a lint job (or extend the test job) that runs ruff check . on the backend.
  3. Run tsc --noEmit on the frontend to catch TypeScript type errors.
  4. Both checks should block the build on failure.
  5. Fix any pre-existing lint or type errors surfaced by these tools before marking the issue complete.

Acceptance criteria

  • ruff check . passes with zero errors on the current codebase (or all suppressions are documented).
  • tsc --noEmit passes on the frontend.
  • CI fails if either check reports errors.
## Context There is no linting or type-checking step in CI. Style issues and TypeScript type errors can be merged undetected. Roadmap reference: ROADMAP.md > P2 > CI/CD > No linting or type checking ## What to do 1. Add `ruff` to the Python dev dependencies and configure it in `pyproject.toml` (or `ruff.toml`). 2. Add a lint job (or extend the test job) that runs `ruff check .` on the backend. 3. Run `tsc --noEmit` on the frontend to catch TypeScript type errors. 4. Both checks should block the build on failure. 5. Fix any pre-existing lint or type errors surfaced by these tools before marking the issue complete. ## Acceptance criteria - [ ] `ruff check .` passes with zero errors on the current codebase (or all suppressions are documented). - [ ] `tsc --noEmit` passes on the frontend. - [ ] CI fails if either check reports errors.
AI-Manager added the P2agent-readymediumci labels 2026-03-30 04:24:38 +00:00
AI-Manager commented 2026-03-30 05:05:00 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved on main. .gitea/workflows/test.yaml includes both a ruff linter step (lines 33-35: ruff check SPARC/ tests/) and a TypeScript type check step (lines 53-56: npx tsc --noEmit). Closing as complete.

This issue has been resolved on main. `.gitea/workflows/test.yaml` includes both a ruff linter step (lines 33-35: `ruff check SPARC/ tests/`) and a TypeScript type check step (lines 53-56: `npx tsc --noEmit`). Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1208
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?