leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #121

New Issue
Closed
opened 2026-03-26 16:22:28 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:22:28 +00:00
Owner
Copy Link
Copy Source

Context

The /auth/login and /auth/register endpoints have no protection against brute-force or credential-stuffing attacks. An attacker can make unlimited requests.

Work

  • Add rate limiting middleware (e.g., slowapi for FastAPI) to the application.
  • Apply a per-IP rate limit to /auth/login (e.g., 10 requests per minute) and /auth/register (e.g., 5 requests per minute).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Document the rate limit configuration via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER).

Acceptance Criteria

  • Sending more than the configured number of requests per minute to /auth/login results in HTTP 429.
  • The Retry-After header is present in the 429 response.
  • Rate limits are configurable via environment variables without code changes.
  • Existing auth tests continue to pass (mock or disable rate limiting in tests).

References

Roadmap: P1 — Error handling and resilience — No rate limiting on auth endpoints.

## Context The `/auth/login` and `/auth/register` endpoints have no protection against brute-force or credential-stuffing attacks. An attacker can make unlimited requests. ## Work - Add rate limiting middleware (e.g., `slowapi` for FastAPI) to the application. - Apply a per-IP rate limit to `/auth/login` (e.g., 10 requests per minute) and `/auth/register` (e.g., 5 requests per minute). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Document the rate limit configuration via environment variables (`AUTH_RATE_LIMIT_LOGIN`, `AUTH_RATE_LIMIT_REGISTER`). ## Acceptance Criteria - Sending more than the configured number of requests per minute to `/auth/login` results in HTTP 429. - The `Retry-After` header is present in the 429 response. - Rate limits are configurable via environment variables without code changes. - Existing auth tests continue to pass (mock or disable rate limiting in tests). ## References Roadmap: P1 — Error handling and resilience — No rate limiting on auth endpoints.
AI-Manager added the P1agent-readymedium labels 2026-03-26 16:22:28 +00:00
AI-Manager commented 2026-03-26 17:03:04 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. Rate limiting is implemented using slowapi in SPARC/api.py: /auth/register is limited to 5/minute and /auth/login is limited to 10/minute. A custom rate_limit_handler returns 429 with a Retry-After header.

Resolved by prior work. Closing.

This issue has already been resolved. Rate limiting is implemented using `slowapi` in `SPARC/api.py`: `/auth/register` is limited to 5/minute and `/auth/login` is limited to 10/minute. A custom `rate_limit_handler` returns 429 with a `Retry-After` header. Resolved by prior work. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?