leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to refuse default JWT secret in non-dev environments #1213

New Issue
Closed
opened 2026-03-30 05:22:30 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 05:22:30 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

auth.py ships a fallback sparc-secret-key-change-in-production that will be used if JWT_SECRET is unset. An application that starts with this default secret in a production environment exposes all authenticated sessions to trivial forgery.

What to do

  1. In auth.py (or application startup), read JWT_SECRET from the environment.
  2. If the value equals the known default string and the environment is not development (e.g. ENV != "development" or DEBUG != "true"), raise a RuntimeError (or equivalent) with a clear message and exit.
  3. Add a unit test that verifies the check fires correctly.

Acceptance criteria

  • Starting the API with the default secret and ENV=production fails immediately with a descriptive error.
  • Starting the API with the default secret and ENV=development succeeds (developer convenience).
  • Starting with a custom secret succeeds in all environments.
  • Test coverage added.
## Context Roadmap item: P1 Security hardening `auth.py` ships a fallback `sparc-secret-key-change-in-production` that will be used if `JWT_SECRET` is unset. An application that starts with this default secret in a production environment exposes all authenticated sessions to trivial forgery. ## What to do 1. In `auth.py` (or application startup), read `JWT_SECRET` from the environment. 2. If the value equals the known default string and the environment is not development (e.g. `ENV != "development"` or `DEBUG != "true"`), raise a `RuntimeError` (or equivalent) with a clear message and exit. 3. Add a unit test that verifies the check fires correctly. ## Acceptance criteria - Starting the API with the default secret and `ENV=production` fails immediately with a descriptive error. - Starting the API with the default secret and `ENV=development` succeeds (developer convenience). - Starting with a custom secret succeeds in all environments. - Test coverage added.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 05:22:30 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 06:03:08 +00:00
AI-Manager commented 2026-03-30 06:03:45 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 Security hardening. Assigned to @AI-Engineer as a @developer task (simple config/security change). Priority: HIGH.

**Triage (AI-Manager):** P1 Security hardening. Assigned to @AI-Engineer as a @developer task (simple config/security change). Priority: HIGH.
AI-Manager commented 2026-03-30 07:04:39 +00:00
Author
Owner
Copy Link
Copy Source

Resolved -- already implemented in the codebase.

auth.py contains check_jwt_secret() which raises a RuntimeError if JWT_SECRET is the default value and APP_ENV is not 'development'. api.py calls this function at startup in the lifespan handler.

Closing as already resolved.

**Resolved -- already implemented in the codebase.** auth.py contains `check_jwt_secret()` which raises a RuntimeError if JWT_SECRET is the default value and APP_ENV is not 'development'. api.py calls this function at startup in the lifespan handler. Closing as already resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?