leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth flow tests: registration, login, protected routes, token refresh, and admin endpoints #122

New Issue
Closed
opened 2026-03-26 16:22:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:22:39 +00:00
Owner
Copy Link
Copy Source

Context

The existing API tests in tests/test_api.py bypass authentication entirely. This means the JWT implementation (registration, login, token validation, refresh, and admin-only access control) is untested.

Work

  • Add test cases for:
    • User registration (POST /auth/register) — success and duplicate-user cases.
    • User login (POST /auth/login) — valid credentials, invalid credentials.
    • Accessing a protected route without a token — expect HTTP 401.
    • Accessing a protected route with a valid token — expect success.
    • Token refresh endpoint — valid refresh token returns new access token.
    • Admin-only endpoint accessed by a non-admin user — expect HTTP 403.
  • Use pytest fixtures for creating test users and obtaining tokens.
  • Tests must not depend on external services (mock the database if needed).

Acceptance Criteria

  • All new test cases pass in CI.
  • Protected routes return 401 without a token and 200 with a valid one.
  • Admin routes return 403 for non-admin users.
  • pytest completes without requiring a running database (use fixtures or test DB).

References

Roadmap: P1 — Test coverage for auth and admin.

## Context The existing API tests in `tests/test_api.py` bypass authentication entirely. This means the JWT implementation (registration, login, token validation, refresh, and admin-only access control) is untested. ## Work - Add test cases for: - User registration (`POST /auth/register`) — success and duplicate-user cases. - User login (`POST /auth/login`) — valid credentials, invalid credentials. - Accessing a protected route without a token — expect HTTP 401. - Accessing a protected route with a valid token — expect success. - Token refresh endpoint — valid refresh token returns new access token. - Admin-only endpoint accessed by a non-admin user — expect HTTP 403. - Use pytest fixtures for creating test users and obtaining tokens. - Tests must not depend on external services (mock the database if needed). ## Acceptance Criteria - All new test cases pass in CI. - Protected routes return 401 without a token and 200 with a valid one. - Admin routes return 403 for non-admin users. - `pytest` completes without requiring a running database (use fixtures or test DB). ## References Roadmap: P1 — Test coverage for auth and admin.
AI-Manager added the P1agent-readymedium labels 2026-03-26 16:22:39 +00:00
AI-Manager commented 2026-03-26 17:03:06 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. Comprehensive JWT auth flow tests exist in tests/test_auth.py covering registration, login, protected routes, token refresh, and admin endpoints.

Resolved by PR #35 ("test(auth): add comprehensive JWT authentication test suite"). Closing.

This issue has already been resolved. Comprehensive JWT auth flow tests exist in `tests/test_auth.py` covering registration, login, protected routes, token refresh, and admin endpoints. Resolved by PR #35 ("test(auth): add comprehensive JWT authentication test suite"). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#122
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?