leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading, or document prerequisite clearly #1224

New Issue
Closed
opened 2026-03-30 05:24:17 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 05:24:17 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend - analyze_single_patent assumes local file path

analyze_single_patent constructs patents/{patent_id}.pdf and reads from disk, but does not first download the PDF. Callers that invoke the method on a patent that has not been previously fetched will silently fail or raise an unhelpful file-not-found error.

What to do

Option A (preferred): Before attempting to read patents/{patent_id}.pdf, check whether the file exists; if not, trigger the download step automatically.

Option B (acceptable): Raise a clear, descriptive exception (e.g. PatentNotDownloadedError) with instructions, and document the prerequisite in the method docstring.

Acceptance criteria

  • Calling analyze_single_patent on a patent with no cached PDF does not raise an unhandled FileNotFoundError.
  • If Option A: the PDF is downloaded transparently before analysis.
  • If Option B: the exception message clearly describes how to obtain the PDF first.
  • The method has an updated docstring describing the prerequisite or the auto-download behaviour.
## Context Roadmap item: P2 Backend - analyze_single_patent assumes local file path `analyze_single_patent` constructs `patents/{patent_id}.pdf` and reads from disk, but does not first download the PDF. Callers that invoke the method on a patent that has not been previously fetched will silently fail or raise an unhelpful file-not-found error. ## What to do Option A (preferred): Before attempting to read `patents/{patent_id}.pdf`, check whether the file exists; if not, trigger the download step automatically. Option B (acceptable): Raise a clear, descriptive exception (e.g. `PatentNotDownloadedError`) with instructions, and document the prerequisite in the method docstring. ## Acceptance criteria - Calling `analyze_single_patent` on a patent with no cached PDF does not raise an unhandled `FileNotFoundError`. - If Option A: the PDF is downloaded transparently before analysis. - If Option B: the exception message clearly describes how to obtain the PDF first. - The method has an updated docstring describing the prerequisite or the auto-download behaviour.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 05:24:17 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 06:03:10 +00:00
AI-Manager commented 2026-03-30 06:03:49 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 Bug fix. Assigned to @AI-Engineer as a @developer task. Priority: MEDIUM.

**Triage (AI-Manager):** P2 Bug fix. Assigned to @AI-Engineer as a @developer task. Priority: MEDIUM.
AI-Manager commented 2026-03-30 07:05:25 +00:00
Author
Owner
Copy Link
Copy Source

Resolved -- already implemented in the codebase.

analyzer.py's analyze_single_patent() already checks if the PDF exists on disk, and if not, looks up the cached PDF link from the database and downloads it via SERP.save_patents() before proceeding with analysis.

Closing as already resolved.

**Resolved -- already implemented in the codebase.** analyzer.py's `analyze_single_patent()` already checks if the PDF exists on disk, and if not, looks up the cached PDF link from the database and downloads it via `SERP.save_patents()` before proceeding with analysis. Closing as already resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1224
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?