leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #123

New Issue
Closed
opened 2026-03-26 16:22:47 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:22:47 +00:00
Owner
Copy Link
Copy Source

Context

analyzer.py, serp_api.py, and llm.py use print() for diagnostic output. This makes log level filtering, structured output, and log aggregation (e.g., in Kubernetes) impossible.

Work

  • Add import logging and create a module-level logger (logger = logging.getLogger(__name__)) in each of the three files.
  • Replace all print() calls with appropriate logger.info(), logger.warning(), or logger.error() calls.
  • Configure a root logging setup (level, format) in the application entrypoint or a logging_config.py module.
  • Ensure log level is configurable via a LOG_LEVEL environment variable.

Acceptance Criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Running the application with LOG_LEVEL=DEBUG produces verbose output; LOG_LEVEL=WARNING suppresses info logs.
  • Existing tests continue to pass.

References

Roadmap: P2 — Backend — Add structured logging.

## Context `analyzer.py`, `serp_api.py`, and `llm.py` use `print()` for diagnostic output. This makes log level filtering, structured output, and log aggregation (e.g., in Kubernetes) impossible. ## Work - Add `import logging` and create a module-level logger (`logger = logging.getLogger(__name__)`) in each of the three files. - Replace all `print()` calls with appropriate `logger.info()`, `logger.warning()`, or `logger.error()` calls. - Configure a root logging setup (level, format) in the application entrypoint or a `logging_config.py` module. - Ensure log level is configurable via a `LOG_LEVEL` environment variable. ## Acceptance Criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - Running the application with `LOG_LEVEL=DEBUG` produces verbose output; `LOG_LEVEL=WARNING` suppresses info logs. - Existing tests continue to pass. ## References Roadmap: P2 — Backend — Add structured logging.
AI-Manager added the P2agent-readysmall labels 2026-03-26 16:22:47 +00:00
AI-Manager commented 2026-03-26 17:03:12 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. All three files (analyzer.py, serp_api.py, llm.py) now use structured logging via logging.getLogger(__name__) instead of print() calls.

Resolved by PR #29 and PR #54. Closing.

This issue has already been resolved. All three files (`analyzer.py`, `serp_api.py`, `llm.py`) now use structured `logging` via `logging.getLogger(__name__)` instead of `print()` calls. Resolved by PR #29 and PR #54. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?