leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #1246

New Issue
Closed
opened 2026-03-30 07:23:40 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 07:23:40 +00:00
Owner
Copy Link
Copy Source

Context

analyzer.py, serp_api.py, and llm.py use bare print() statements for diagnostic output. This makes it impossible to control log levels, filter by severity, or integrate with a log aggregator.

Roadmap reference: ROADMAP.md > P2 > Backend > Add structured logging

What to do

  1. Create or configure a project-level logger (e.g. logging.getLogger("sparc")) in a shared logging_config.py.
  2. Replace all print() calls in the three named files with appropriate logger.debug(), logger.info(), or logger.error() calls.
  3. Configure log level from the LOG_LEVEL environment variable (default INFO).
  4. Ensure the log format includes timestamp, level, and module name.

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Setting LOG_LEVEL=DEBUG produces verbose output; LOG_LEVEL=WARNING suppresses info messages.
  • Existing tests still pass.
## Context `analyzer.py`, `serp_api.py`, and `llm.py` use bare `print()` statements for diagnostic output. This makes it impossible to control log levels, filter by severity, or integrate with a log aggregator. Roadmap reference: ROADMAP.md > P2 > Backend > Add structured logging ## What to do 1. Create or configure a project-level logger (e.g. `logging.getLogger("sparc")`) in a shared `logging_config.py`. 2. Replace all `print()` calls in the three named files with appropriate `logger.debug()`, `logger.info()`, or `logger.error()` calls. 3. Configure log level from the `LOG_LEVEL` environment variable (default `INFO`). 4. Ensure the log format includes timestamp, level, and module name. ## Acceptance criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - Setting `LOG_LEVEL=DEBUG` produces verbose output; `LOG_LEVEL=WARNING` suppresses info messages. - Existing tests still pass.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-30 07:23:40 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 08:03:22 +00:00
AI-Manager commented 2026-03-30 08:04:59 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 config/refactor, small scope. Assigned to AI-Engineer. Recommended agent: @developer. Straightforward environment variable or logging change.

**Triage (AI-Manager):** P2 config/refactor, small scope. Assigned to AI-Engineer. Recommended agent: @developer. Straightforward environment variable or logging change.
AI-Manager commented 2026-03-30 09:04:48 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Priority Tier 4 - P2 Infrastructure and Config

This is a P2 infrastructure/config improvement. Should be worked after Tier 1-3 items.

Agent type: @developer (small, well-scoped change)

Dependencies: #1247 (MODEL env var) should be done before #1264 (multi-model support).

-- AI-Manager triage, 2026-03-30

## Triage: Priority Tier 4 - P2 Infrastructure and Config This is a **P2 infrastructure/config** improvement. Should be worked after Tier 1-3 items. **Agent type:** @developer (small, well-scoped change) Dependencies: #1247 (MODEL env var) should be done before #1264 (multi-model support). -- AI-Manager triage, 2026-03-30
AI-Manager commented 2026-03-30 09:07:51 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Already Resolved

This issue has been implemented and merged into main.

Resolved by PR #29 (feat: configurable LLM model, SERP cache TTL, structured logging, fix type) and PR #54. All modules use logging.getLogger(); no print() calls remain.

Closing as completed.

-- AI-Manager, 2026-03-30

## Closing: Already Resolved This issue has been implemented and merged into main. Resolved by PR #29 (feat: configurable LLM model, SERP cache TTL, structured logging, fix type) and PR #54. All modules use logging.getLogger(); no print() calls remain. Closing as completed. -- AI-Manager, 2026-03-30
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?