leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #125

New Issue
Closed
opened 2026-03-26 16:23:11 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:23:11 +00:00
Owner
Copy Link
Copy Source

Context

The analyze_single_patent method constructs a local path patents/{patent_id}.pdf and reads from disk, but does not download the PDF first. This causes a FileNotFoundError unless the caller has already downloaded the file out-of-band.

Work

  • Integrate the download step into analyze_single_patent: call the SerpAPI/patent-fetch logic before attempting to read the local file.
  • Alternatively, if the download is the caller responsibility, add a clear check at the start of the method that raises a descriptive ValueError if the file does not exist, with instructions on how to download it.
  • Update relevant tests to cover the download-then-analyze path.

Acceptance Criteria

  • Calling analyze_single_patent(patent_id) for a patent not yet on disk either downloads it automatically or raises a descriptive error (not a bare FileNotFoundError).
  • No regression in existing analysis tests.

References

Roadmap: P2 -- Backend -- analyze_single_patent assumes local file path.

## Context The analyze_single_patent method constructs a local path patents/{patent_id}.pdf and reads from disk, but does not download the PDF first. This causes a FileNotFoundError unless the caller has already downloaded the file out-of-band. ## Work - Integrate the download step into analyze_single_patent: call the SerpAPI/patent-fetch logic before attempting to read the local file. - Alternatively, if the download is the caller responsibility, add a clear check at the start of the method that raises a descriptive ValueError if the file does not exist, with instructions on how to download it. - Update relevant tests to cover the download-then-analyze path. ## Acceptance Criteria - Calling analyze_single_patent(patent_id) for a patent not yet on disk either downloads it automatically or raises a descriptive error (not a bare FileNotFoundError). - No regression in existing analysis tests. ## References Roadmap: P2 -- Backend -- analyze_single_patent assumes local file path.
AI-Manager added the P2agent-readysmall labels 2026-03-26 16:23:11 +00:00
AI-Manager commented 2026-03-26 17:03:16 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. analyze_single_patent in SPARC/analyzer.py now downloads the PDF before reading from disk (see line 137: auto-download when PDF is not on disk).

Resolved by PR #55 ("fix: auto-download patent PDF in analyze_single_patent"). Closing.

This issue has already been resolved. `analyze_single_patent` in `SPARC/analyzer.py` now downloads the PDF before reading from disk (see line 137: auto-download when PDF is not on disk). Resolved by PR #55 ("fix: auto-download patent PDF in analyze_single_patent"). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?