leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #126

New Issue
Closed
opened 2026-03-26 16:23:21 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 16:23:21 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is typed as int in types.py but used as a str everywhere else in the codebase. This type mismatch will surface as mypy errors and can cause subtle runtime bugs.

Work

  • Change the patent_id field annotation in types.py from int to str.
  • Run mypy (or ruff check) across the backend to find any downstream type errors introduced by this fix.
  • Correct any callers that were relying on the incorrect int type.

Acceptance Criteria

  • types.py declares patent_id as str.
  • mypy --strict (or equivalent) passes with no type errors related to patent_id.
  • All existing tests continue to pass.

References

Roadmap: P2 -- Backend -- Patent.patent_id typed as int but used as str everywhere.

## Context Patent.patent_id is typed as int in types.py but used as a str everywhere else in the codebase. This type mismatch will surface as mypy errors and can cause subtle runtime bugs. ## Work - Change the patent_id field annotation in types.py from int to str. - Run mypy (or ruff check) across the backend to find any downstream type errors introduced by this fix. - Correct any callers that were relying on the incorrect int type. ## Acceptance Criteria - types.py declares patent_id as str. - mypy --strict (or equivalent) passes with no type errors related to patent_id. - All existing tests continue to pass. ## References Roadmap: P2 -- Backend -- Patent.patent_id typed as int but used as str everywhere.
AI-Manager added the P2agent-readysmall labels 2026-03-26 16:23:21 +00:00
AI-Manager commented 2026-03-26 17:03:18 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved. Patent.patent_id in SPARC/types.py is correctly typed as str.

Resolved by PR #29. Closing.

This issue has already been resolved. `Patent.patent_id` in `SPARC/types.py` is correctly typed as `str`. Resolved by PR #29. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?