leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse to start with default JWT secret in non-development environments #1265

New Issue
Closed
opened 2026-03-30 09:21:51 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:21:51 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. This means a misconfigured production deployment silently runs with a known, public secret.

Roadmap reference: P1 - Security hardening

What to do

  • Add a startup check (e.g., in a FastAPI lifespan handler or __init__) that reads JWT_SECRET from the environment.
  • If the value equals the default fallback string AND the current environment is not development (check APP_ENV or similar), raise a RuntimeError or call sys.exit(1) with a clear message.
  • Document JWT_SECRET and APP_ENV in the README / .env.example.

Acceptance criteria

  • Starting the API without JWT_SECRET set (and APP_ENV != development) fails fast with a descriptive error message.
  • Starting with APP_ENV=development and the default secret succeeds.
  • Unit test covers both code paths.
## Context `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. This means a misconfigured production deployment silently runs with a known, public secret. Roadmap reference: P1 - Security hardening ## What to do - Add a startup check (e.g., in a FastAPI `lifespan` handler or `__init__`) that reads `JWT_SECRET` from the environment. - If the value equals the default fallback string AND the current environment is not `development` (check `APP_ENV` or similar), raise a `RuntimeError` or call `sys.exit(1)` with a clear message. - Document `JWT_SECRET` and `APP_ENV` in the README / `.env.example`. ## Acceptance criteria - Starting the API without `JWT_SECRET` set (and `APP_ENV != development`) fails fast with a descriptive error message. - Starting with `APP_ENV=development` and the default secret succeeds. - Unit test covers both code paths.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 09:21:51 +00:00
AI-Manager commented 2026-03-30 10:04:03 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

This feature is fully implemented in the current codebase on main:

  • SPARC/auth.py defines check_jwt_secret() (line 23-33) which raises RuntimeError when JWT_SECRET equals the default value and APP_ENV is not development.
  • SPARC/api.py calls check_jwt_secret() at startup in the lifespan() handler (line 181).
  • SPARC/config.py reads APP_ENV from environment (line 54), defaulting to development.
  • docker-compose.yml passes APP_ENV via ${APP_ENV:-development}.

All acceptance criteria are met. Closing as completed.

## Triage: Already Implemented This feature is fully implemented in the current codebase on `main`: - `SPARC/auth.py` defines `check_jwt_secret()` (line 23-33) which raises `RuntimeError` when `JWT_SECRET` equals the default value and `APP_ENV` is not `development`. - `SPARC/api.py` calls `check_jwt_secret()` at startup in the `lifespan()` handler (line 181). - `SPARC/config.py` reads `APP_ENV` from environment (line 54), defaulting to `development`. - `docker-compose.yml` passes `APP_ENV` via `${APP_ENV:-development}`. All acceptance criteria are met. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1265
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?