leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1266

New Issue
Closed
opened 2026-03-30 09:21:59 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:21:59 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes localhost:3000 and localhost:5173 as the only CORS allowed origins. This blocks the dashboard from working on any real domain without a code change.

Roadmap reference: P1 - Security hardening

What to do

  • Read allowed origins from a CORS_ORIGINS environment variable (comma-separated list).
  • Fall back to localhost:3000,localhost:5173 when the variable is absent.
  • Add CORS_ORIGINS to .env.example with a comment.
  • Update config.py to parse and expose this setting.

Acceptance criteria

  • Setting CORS_ORIGINS=https://sparc.example.com results in only that origin being allowed.
  • Omitting the variable keeps existing local-dev defaults.
  • No origins are hardcoded in api.py.
## Context `api.py` hardcodes `localhost:3000` and `localhost:5173` as the only CORS allowed origins. This blocks the dashboard from working on any real domain without a code change. Roadmap reference: P1 - Security hardening ## What to do - Read allowed origins from a `CORS_ORIGINS` environment variable (comma-separated list). - Fall back to `localhost:3000,localhost:5173` when the variable is absent. - Add `CORS_ORIGINS` to `.env.example` with a comment. - Update `config.py` to parse and expose this setting. ## Acceptance criteria - Setting `CORS_ORIGINS=https://sparc.example.com` results in only that origin being allowed. - Omitting the variable keeps existing local-dev defaults. - No origins are hardcoded in `api.py`.
AI-Manager added the P1agent-readysmallsecurityconfig labels 2026-03-30 09:21:59 +00:00
AI-Manager commented 2026-03-30 10:04:13 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

This feature is fully implemented in the current codebase on main:

  • SPARC/config.py reads CORS_ORIGINS env var (lines 65-70), splits on comma, and falls back to localhost:3000 and localhost:5173 when unset.
  • SPARC/api.py uses config.cors_origins in the CORS middleware (line 230).
  • docker-compose.yml passes CORS_ORIGINS via ${CORS_ORIGINS:-}.
  • .env.example documents the variable.

All acceptance criteria are met. Closing as completed.

## Triage: Already Implemented This feature is fully implemented in the current codebase on `main`: - `SPARC/config.py` reads `CORS_ORIGINS` env var (lines 65-70), splits on comma, and falls back to `localhost:3000` and `localhost:5173` when unset. - `SPARC/api.py` uses `config.cors_origins` in the CORS middleware (line 230). - `docker-compose.yml` passes `CORS_ORIGINS` via `${CORS_ORIGINS:-}`. - `.env.example` documents the variable. All acceptance criteria are met. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?