leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests: registration, login, protected routes, token refresh, admin endpoints #1271

New Issue
Closed
opened 2026-03-30 09:23:01 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:23:01 +00:00
Owner
Copy Link
Copy Source

Context

The existing tests/test_api.py suite bypasses authentication entirely. There is zero test coverage for the JWT flow, meaning regressions in auth go undetected.

Roadmap reference: P1 - Test coverage for auth and admin

What to do

Add a new test file tests/test_auth.py (or extend test_api.py) covering:

  1. Registration - valid new user, duplicate username returns 409.
  2. Login - correct credentials return a JWT; wrong password returns 401.
  3. Protected route access - request without token returns 401; valid token succeeds.
  4. Token refresh - refresh endpoint returns a new access token; expired/invalid refresh token returns 401.
  5. Admin-only endpoints - non-admin JWT receives 403; admin JWT succeeds.

Use pytest fixtures to create test users and clean up after each test. Mock external services (database) where appropriate.

Acceptance criteria

  • All five scenario groups have passing tests.
  • pytest tests/test_auth.py exits 0 in CI.
  • No test relies on a running database (use mocks or a test database fixture).
## Context The existing `tests/test_api.py` suite bypasses authentication entirely. There is zero test coverage for the JWT flow, meaning regressions in auth go undetected. Roadmap reference: P1 - Test coverage for auth and admin ## What to do Add a new test file `tests/test_auth.py` (or extend `test_api.py`) covering: 1. **Registration** - valid new user, duplicate username returns 409. 2. **Login** - correct credentials return a JWT; wrong password returns 401. 3. **Protected route access** - request without token returns 401; valid token succeeds. 4. **Token refresh** - refresh endpoint returns a new access token; expired/invalid refresh token returns 401. 5. **Admin-only endpoints** - non-admin JWT receives 403; admin JWT succeeds. Use `pytest` fixtures to create test users and clean up after each test. Mock external services (database) where appropriate. ## Acceptance criteria - All five scenario groups have passing tests. - `pytest tests/test_auth.py` exits 0 in CI. - No test relies on a running database (use mocks or a test database fixture).
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 09:23:01 +00:00
AI-Manager commented 2026-03-30 10:04:54 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

JWT authentication tests exist on main:

  • tests/test_auth.py covers registration, login, protected routes, token refresh, and admin endpoints with mocked database.
  • tests/test_security.py covers security-specific auth scenarios.
  • tests/test_rate_limit.py covers rate limiting on auth endpoints.
  • The CI workflow (test.yaml) runs all tests with pytest tests/ -v.

Closing as completed.

## Triage: Already Implemented JWT authentication tests exist on `main`: - `tests/test_auth.py` covers registration, login, protected routes, token refresh, and admin endpoints with mocked database. - `tests/test_security.py` covers security-specific auth scenarios. - `tests/test_rate_limit.py` covers rate limiting on auth endpoints. - The CI workflow (`test.yaml`) runs all tests with `pytest tests/ -v`. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?