leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #1272

New Issue
Closed
opened 2026-03-30 09:23:08 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:23:08 +00:00
Owner
Copy Link
Copy Source

Context

Multiple backend modules use print() for diagnostic output. This prevents log-level filtering, structured formatting, and centralised log aggregation.

Roadmap reference: P2 - Backend: Add structured logging

What to do

  • Add a logging configuration module (e.g., backend/logging_config.py) that sets up a root logger with a consistent format (timestamp, level, module, message) configurable via LOG_LEVEL env var.
  • Replace all print() calls in analyzer.py, serp_api.py, and llm.py with logger = logging.getLogger(__name__) and appropriate levels (debug, info, warning, error).
  • Call the logging setup at application startup.

Acceptance criteria

  • No print() calls remain in the three target files.
  • Setting LOG_LEVEL=DEBUG emits verbose output; LOG_LEVEL=WARNING suppresses info messages.
  • Existing tests continue to pass.
## Context Multiple backend modules use `print()` for diagnostic output. This prevents log-level filtering, structured formatting, and centralised log aggregation. Roadmap reference: P2 - Backend: Add structured logging ## What to do - Add a `logging` configuration module (e.g., `backend/logging_config.py`) that sets up a root logger with a consistent format (timestamp, level, module, message) configurable via `LOG_LEVEL` env var. - Replace all `print()` calls in `analyzer.py`, `serp_api.py`, and `llm.py` with `logger = logging.getLogger(__name__)` and appropriate levels (`debug`, `info`, `warning`, `error`). - Call the logging setup at application startup. ## Acceptance criteria - No `print()` calls remain in the three target files. - Setting `LOG_LEVEL=DEBUG` emits verbose output; `LOG_LEVEL=WARNING` suppresses info messages. - Existing tests continue to pass.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-30 09:23:08 +00:00
AI-Manager commented 2026-03-30 10:05:30 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

Structured logging is fully implemented on main:

  • Zero print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • SPARC/config.py configures logging.basicConfig() with a structured format (%(asctime)s %(levelname)s %(name)s %(message)s) and reads LOG_LEVEL from the environment.
  • All modules use logging.getLogger(__name__) for output.

Closing as completed.

## Triage: Already Implemented Structured logging is fully implemented on `main`: - Zero `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - `SPARC/config.py` configures `logging.basicConfig()` with a structured format (`%(asctime)s %(levelname)s %(name)s %(message)s`) and reads `LOG_LEVEL` from the environment. - All modules use `logging.getLogger(__name__)` for output. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?