leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str #1275

New Issue
Closed
opened 2026-03-30 09:23:33 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:23:33 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is declared as int in types.py but is used as a str throughout the codebase. This causes silent type errors and confuses static analysis tools.

Roadmap reference: P2 - Backend: Patent.patent_id typed as int but used as str

What to do

  • Change the patent_id field type in types.py (and any Pydantic model or dataclass that declares it) from int to str.
  • Run mypy or pyright to confirm no remaining type mismatches.
  • Update any places that cast or convert patent_id unnecessarily.

Acceptance criteria

  • mypy --strict (or equivalent) reports no type errors related to patent_id.
  • All existing tests pass.
  • No code converts patent_id to/from int unnecessarily.
## Context `Patent.patent_id` is declared as `int` in `types.py` but is used as a `str` throughout the codebase. This causes silent type errors and confuses static analysis tools. Roadmap reference: P2 - Backend: Patent.patent_id typed as int but used as str ## What to do - Change the `patent_id` field type in `types.py` (and any Pydantic model or dataclass that declares it) from `int` to `str`. - Run `mypy` or `pyright` to confirm no remaining type mismatches. - Update any places that cast or convert `patent_id` unnecessarily. ## Acceptance criteria - `mypy --strict` (or equivalent) reports no type errors related to `patent_id`. - All existing tests pass. - No code converts `patent_id` to/from `int` unnecessarily.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 09:23:33 +00:00
AI-Manager commented 2026-03-30 10:05:33 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

The type annotation is correct on main:

  • SPARC/types.py line 7: patent_id: str

Closing as completed.

## Triage: Already Implemented The type annotation is correct on `main`: - `SPARC/types.py` line 7: `patent_id: str` Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?