leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #1278

New Issue
Closed
opened 2026-03-30 09:24:10 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:24:10 +00:00
Owner
Copy Link
Copy Source

Context

The frontend directory has no committed lockfile. This means npm install / pnpm install can silently resolve different dependency versions across developer machines and CI runs, making builds non-reproducible.

Roadmap reference: P2 - Frontend: Missing package-lock.json or pnpm-lock.yaml

What to do

  • Decide on and document the preferred package manager (npm or pnpm).
  • Generate the lockfile (npm install or pnpm install) locally and commit it.
  • Update .gitignore to NOT ignore the lockfile (remove any rule that excludes it).
  • Update the CI workflow to run npm ci (or pnpm install --frozen-lockfile) to enforce the lockfile.

Acceptance criteria

  • A lockfile exists at frontend/package-lock.json or frontend/pnpm-lock.yaml.
  • CI uses the locked install command.
  • Two consecutive npm ci runs produce identical node_modules contents.
## Context The frontend directory has no committed lockfile. This means `npm install` / `pnpm install` can silently resolve different dependency versions across developer machines and CI runs, making builds non-reproducible. Roadmap reference: P2 - Frontend: Missing package-lock.json or pnpm-lock.yaml ## What to do - Decide on and document the preferred package manager (npm or pnpm). - Generate the lockfile (`npm install` or `pnpm install`) locally and commit it. - Update `.gitignore` to NOT ignore the lockfile (remove any rule that excludes it). - Update the CI workflow to run `npm ci` (or `pnpm install --frozen-lockfile`) to enforce the lockfile. ## Acceptance criteria - A lockfile exists at `frontend/package-lock.json` or `frontend/pnpm-lock.yaml`. - CI uses the locked install command. - Two consecutive `npm ci` runs produce identical `node_modules` contents.
AI-Manager added the P2agent-readysmallinfra labels 2026-03-30 09:24:10 +00:00
AI-Manager commented 2026-03-30 10:05:37 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

frontend/package-lock.json is committed on main. The CI workflow uses npm ci for reproducible installs.

Closing as completed.

## Triage: Already Implemented `frontend/package-lock.json` is committed on `main`. The CI workflow uses `npm ci` for reproducible installs. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready infra small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?