leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1280

New Issue
Closed
opened 2026-03-30 09:24:32 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 09:24:32 +00:00
Owner
Copy Link
Copy Source

Context

There is no linting or static type checking in CI. Style violations and type errors are only caught (if at all) during code review.

Roadmap reference: P2 - CI/CD: No linting or type checking

What to do

  • Add ruff to the backend dev dependencies (requirements-dev.txt or pyproject.toml) and run ruff check . in CI.
  • Add a tsc --noEmit step in the frontend CI job (TypeScript is already a dependency).
  • Both checks should run on every PR and push to main.
  • Fix any pre-existing lint or type errors surfaced by the new checks.

Acceptance criteria

  • CI fails when new ruff violations are introduced.
  • CI fails when new TypeScript type errors are introduced.
  • The initial run is green (all existing issues resolved or suppressed with documented exceptions).
## Context There is no linting or static type checking in CI. Style violations and type errors are only caught (if at all) during code review. Roadmap reference: P2 - CI/CD: No linting or type checking ## What to do - Add `ruff` to the backend dev dependencies (`requirements-dev.txt` or `pyproject.toml`) and run `ruff check .` in CI. - Add a `tsc --noEmit` step in the frontend CI job (TypeScript is already a dependency). - Both checks should run on every PR and push to `main`. - Fix any pre-existing lint or type errors surfaced by the new checks. ## Acceptance criteria - CI fails when new `ruff` violations are introduced. - CI fails when new TypeScript type errors are introduced. - The initial run is green (all existing issues resolved or suppressed with documented exceptions).
AI-Manager added the P2agent-readymediumci labels 2026-03-30 09:24:32 +00:00
AI-Manager commented 2026-03-30 10:06:15 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Implemented

Both linters are in CI on main:

  • .gitea/workflows/test.yaml runs ruff check SPARC/ tests/ and npx tsc --noEmit in the frontend.
  • .gitea/workflows/build.yaml also includes both checks.
  • ruff.toml is committed with project-specific configuration.

Closing as completed.

## Triage: Already Implemented Both linters are in CI on `main`: - `.gitea/workflows/test.yaml` runs `ruff check SPARC/ tests/` and `npx tsc --noEmit` in the frontend. - `.gitea/workflows/build.yaml` also includes both checks. - `ruff.toml` is committed with project-specific configuration. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1280
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?