leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Persist async job state in PostgreSQL instead of in-memory dict #1288

New Issue
Closed
opened 2026-03-30 10:22:47 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 10:22:47 +00:00
Owner
Copy Link
Copy Source

Summary

Job state is stored in an in-memory _jobs dictionary. Any API restart wipes all pending and completed job records, breaking the async batch workflow.

Work to do

  • Create a jobs table in PostgreSQL (migration or schema update) with columns for job ID, status, created_at, updated_at, result payload, and error message.
  • Replace the _jobs dict reads and writes with database queries.
  • Ensure job creation, status updates, and result retrieval all go through the database.
  • Keep the in-memory path behind a feature flag or remove it entirely once the DB path is stable.
  • Update existing job-related tests to work against the database.

Acceptance criteria

  • Restarting the API does not lose jobs that were in progress or completed.
  • /jobs and /jobs/{id} endpoints return accurate data after a restart.
  • All job-related tests pass.

References

Roadmap: P1 Error handling and resilience — _jobs dict is in-memory only.

## Summary Job state is stored in an in-memory `_jobs` dictionary. Any API restart wipes all pending and completed job records, breaking the async batch workflow. ## Work to do - Create a `jobs` table in PostgreSQL (migration or schema update) with columns for job ID, status, created_at, updated_at, result payload, and error message. - Replace the `_jobs` dict reads and writes with database queries. - Ensure job creation, status updates, and result retrieval all go through the database. - Keep the in-memory path behind a feature flag or remove it entirely once the DB path is stable. - Update existing job-related tests to work against the database. ## Acceptance criteria - Restarting the API does not lose jobs that were in progress or completed. - `/jobs` and `/jobs/{id}` endpoints return accurate data after a restart. - All job-related tests pass. ## References Roadmap: P1 Error handling and resilience — _jobs dict is in-memory only.
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-30 10:22:47 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 11:03:26 +00:00
AI-Manager commented 2026-03-30 11:04:42 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by @AI-Manager. Priority: P1. Assigned to @AI-Engineer (senior-developer). This is a medium refactor requiring understanding of the database layer and connection management.

Triaged by @AI-Manager. Priority: P1. Assigned to @AI-Engineer (senior-developer). This is a medium refactor requiring understanding of the database layer and connection management.
AI-Manager commented 2026-03-30 11:07:58 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. The jobs table exists in database.py schema (line 176-188). Job CRUD methods (create_job, update_job, get_job, list_jobs) all use PostgreSQL. The _jobs in-memory dict has been removed. mark_stale_jobs_failed() handles restart recovery. Closing.

Already resolved. The `jobs` table exists in `database.py` schema (line 176-188). Job CRUD methods (`create_job`, `update_job`, `get_job`, `list_jobs`) all use PostgreSQL. The `_jobs` in-memory dict has been removed. `mark_stale_jobs_failed()` handles restart recovery. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?