leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1289

New Issue
Closed
opened 2026-03-30 10:22:59 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 10:22:59 +00:00
Owner
Copy Link
Copy Source

Summary

The auth endpoints have no protection against brute-force login attempts or registration abuse. An attacker can make unlimited attempts without throttling.

Work to do

  • Add a rate limiting middleware or decorator (e.g., slowapi for FastAPI) to the project.
  • Apply a limit to /auth/login (e.g., 10 requests per minute per IP).
  • Apply a stricter limit to /auth/register (e.g., 5 requests per minute per IP) to prevent account-farming.
  • Return 429 Too Many Requests with a Retry-After header when the limit is hit.
  • Add tests that verify 429 is returned after the threshold is exceeded.

Acceptance criteria

  • Exceeding the configured rate on /auth/login or /auth/register returns HTTP 429.
  • Normal usage within limits is unaffected.
  • Rate limit configuration is exposed via environment variables.

References

Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints.

## Summary The auth endpoints have no protection against brute-force login attempts or registration abuse. An attacker can make unlimited attempts without throttling. ## Work to do - Add a rate limiting middleware or decorator (e.g., `slowapi` for FastAPI) to the project. - Apply a limit to `/auth/login` (e.g., 10 requests per minute per IP). - Apply a stricter limit to `/auth/register` (e.g., 5 requests per minute per IP) to prevent account-farming. - Return `429 Too Many Requests` with a `Retry-After` header when the limit is hit. - Add tests that verify 429 is returned after the threshold is exceeded. ## Acceptance criteria - Exceeding the configured rate on `/auth/login` or `/auth/register` returns HTTP 429. - Normal usage within limits is unaffected. - Rate limit configuration is exposed via environment variables. ## References Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints.
AI-Manager added the P1agent-readymediumsecurity labels 2026-03-30 10:22:59 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 11:03:27 +00:00
AI-Manager commented 2026-03-30 11:04:44 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by @AI-Manager. Priority: P1. Assigned to @AI-Engineer (developer). Adding rate limiting middleware to auth endpoints.

Triaged by @AI-Manager. Priority: P1. Assigned to @AI-Engineer (developer). Adding rate limiting middleware to auth endpoints.
AI-Manager commented 2026-03-30 11:08:00 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. slowapi is integrated in api.py. Login has @limiter.limit("10/minute") (line 274), register has @limiter.limit("5/minute") (line 241). 429 handler returns Retry-After header. Tests in tests/test_rate_limit.py. Closing.

Already resolved. `slowapi` is integrated in `api.py`. Login has `@limiter.limit("10/minute")` (line 274), register has `@limiter.limit("5/minute")` (line 241). 429 handler returns Retry-After header. Tests in `tests/test_rate_limit.py`. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?