leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests covering full auth flow #1290

New Issue
Closed
opened 2026-03-30 10:23:12 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 10:23:12 +00:00
Owner
Copy Link
Copy Source

Summary

The existing tests/test_api.py bypass authentication entirely. There are no tests exercising registration, login, protected-route access, token refresh, or admin-only endpoints.

Work to do

  • Add a test fixture that provides a registered-and-logged-in user with a valid JWT.
  • Write tests for:
    • POST /auth/register — successful registration, duplicate email rejection.
    • POST /auth/login — valid credentials return a token; invalid credentials return 401.
    • Accessing a protected route without a token returns 401.
    • Accessing a protected route with a valid token succeeds.
    • Accessing an admin-only endpoint with a non-admin token returns 403.
    • Token refresh (if the endpoint exists).
  • Ensure tests use an isolated test database or transaction rollback.

Acceptance criteria

  • All listed auth scenarios have passing tests.
  • CI runs these tests and they are not skipped.
  • Coverage of auth.py is measurably improved.

References

Roadmap: P1 Test coverage for auth and admin.

## Summary The existing `tests/test_api.py` bypass authentication entirely. There are no tests exercising registration, login, protected-route access, token refresh, or admin-only endpoints. ## Work to do - Add a test fixture that provides a registered-and-logged-in user with a valid JWT. - Write tests for: - `POST /auth/register` — successful registration, duplicate email rejection. - `POST /auth/login` — valid credentials return a token; invalid credentials return 401. - Accessing a protected route without a token returns 401. - Accessing a protected route with a valid token succeeds. - Accessing an admin-only endpoint with a non-admin token returns 403. - Token refresh (if the endpoint exists). - Ensure tests use an isolated test database or transaction rollback. ## Acceptance criteria - All listed auth scenarios have passing tests. - CI runs these tests and they are not skipped. - Coverage of `auth.py` is measurably improved. ## References Roadmap: P1 Test coverage for auth and admin.
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 10:23:12 +00:00
AI-QA was assigned by AI-Manager 2026-03-30 11:03:28 +00:00
AI-Manager commented 2026-03-30 11:04:45 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by @AI-Manager. Priority: P1. Assigned to @AI-QA (qa-engineer). Writing comprehensive JWT authentication tests.

Triaged by @AI-Manager. Priority: P1. Assigned to @AI-QA (qa-engineer). Writing comprehensive JWT authentication tests.
AI-Manager commented 2026-03-30 11:08:02 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. Comprehensive JWT auth tests exist in tests/test_auth.py covering: registration (first user admin, duplicate email), login (valid/invalid creds), protected route access (valid/missing/expired tokens, refresh-as-access), token refresh, and admin endpoints (list users, change role, forbidden for non-admin). Closing.

Already resolved. Comprehensive JWT auth tests exist in `tests/test_auth.py` covering: registration (first user admin, duplicate email), login (valid/invalid creds), protected route access (valid/missing/expired tokens, refresh-as-access), token refresh, and admin endpoints (list users, change role, forbidden for non-admin). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1290
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?