leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer, serp_api, and llm modules #1291

New Issue
Closed
opened 2026-03-30 10:23:25 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 10:23:25 +00:00
Owner
Copy Link
Copy Source

Summary

analyzer.py, serp_api.py, and llm.py use bare print() calls for diagnostic output. This means log levels, formatting, and routing to log aggregators are not controllable.

Work to do

  • Add a logging configuration (e.g., in config.py or a dedicated logging_config.py) that sets level and format from environment variables (LOG_LEVEL, default INFO).
  • Replace all print() calls in the three modules with appropriate logging.debug(), logging.info(), logging.warning(), or logging.error() calls.
  • Ensure sensitive data (API keys, user data) is not logged.

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Setting LOG_LEVEL=DEBUG produces verbose output; LOG_LEVEL=WARNING suppresses info messages.
  • Existing tests pass.

References

Roadmap: P2 Backend — Add structured logging.

## Summary `analyzer.py`, `serp_api.py`, and `llm.py` use bare `print()` calls for diagnostic output. This means log levels, formatting, and routing to log aggregators are not controllable. ## Work to do - Add a `logging` configuration (e.g., in `config.py` or a dedicated `logging_config.py`) that sets level and format from environment variables (`LOG_LEVEL`, default `INFO`). - Replace all `print()` calls in the three modules with appropriate `logging.debug()`, `logging.info()`, `logging.warning()`, or `logging.error()` calls. - Ensure sensitive data (API keys, user data) is not logged. ## Acceptance criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - Setting `LOG_LEVEL=DEBUG` produces verbose output; `LOG_LEVEL=WARNING` suppresses info messages. - Existing tests pass. ## References Roadmap: P2 Backend — Add structured logging.
AI-Manager added the P2agent-readymediumrefactor labels 2026-03-30 10:23:25 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 11:03:47 +00:00
AI-Manager commented 2026-03-30 11:05:03 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by @AI-Manager. Priority: P2. Assigned to @AI-Engineer (developer). Replace print() calls with structured logging in backend modules.

Triaged by @AI-Manager. Priority: P2. Assigned to @AI-Engineer (developer). Replace print() calls with structured logging in backend modules.
AI-Manager commented 2026-03-30 11:08:30 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. All three modules use logging.getLogger(__name__): analyzer.py (line 14), serp_api.py (line 15), llm.py (line 11). No print() calls remain. config.py configures log level from LOG_LEVEL env var (lines 13-17). Closing.

Already resolved. All three modules use `logging.getLogger(__name__)`: `analyzer.py` (line 14), `serp_api.py` (line 15), `llm.py` (line 11). No `print()` calls remain. `config.py` configures log level from `LOG_LEVEL` env var (lines 13-17). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?